linux-kernel - Re: [PATCH] mbox: qcom: avoid unused-variable warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20191003211601.56450207FF@mail.kernel.org>
Date:   Thu, 03 Oct 2019 14:16:00 -0700
From:   Stephen Boyd <sboyd@...nel.org>
To:     Geert Uytterhoeven <geert@...ux-m68k.org>
Cc:     Arnd Bergmann <arnd@...db.de>,
        Geert Uytterhoeven <geert+renesas@...der.be>,
        Andy Gross <agross@...nel.org>,
        Jassi Brar <jassisinghbrar@...il.com>,
        Niklas Cassel <niklas.cassel@...aro.org>,
        Jorge Ramirez-Ortiz <jorge.ramirez-ortiz@...aro.org>,
        Bjorn Andersson <bjorn.andersson@...aro.org>,
        Jassi Brar <jaswinder.singh@...aro.org>,
        linux-arm-msm <linux-arm-msm@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] mbox: qcom: avoid unused-variable warning

Quoting Geert Uytterhoeven (2019-09-27 12:10:13)
> On Fri, Sep 27, 2019 at 8:26 PM Stephen Boyd <sboyd@...nel.org> wrote:
> > Quoting Geert Uytterhoeven (2019-09-26 06:07:13)
> > > On Fri, Sep 20, 2019 at 11:06 PM Stephen Boyd <sboyd@...nel.org> wrote:
> > > > Quoting Arnd Bergmann (2019-09-20 12:27:50)
> > > > > On Fri, Sep 20, 2019 at 6:45 PM Stephen Boyd <sboyd@...nel.org> wrote:
> > >
> > > > --- a/drivers/leds/leds-pca9532.c
> > > > +++ b/drivers/leds/leds-pca9532.c
> > > > @@ -472,7 +472,7 @@ pca9532_of_populate_pdata(struct device *dev, struct device_node *np)
> > > >         int i = 0;
> > > >         const char *state;
> > > >
> > > > -       match = of_match_device(of_pca9532_leds_match, dev);
> > > > +       match = of_match_device(of_match_ptr(of_pca9532_leds_match), dev);
> > > >         if (!match)
> > > >                 return ERR_PTR(-ENODEV);
> > >
> > > Please convert to of_device_get_match_data() instead of adding
> > > of_match_ptr() invocations...
> >
> > How is this workable? I left it as of_match_device() because the value
> > returned may be 0 for the enum and that looks the same as NULL.
> 
> This function is used for the DT case only, so there will always be a match.
> Hence you can do devid = (int)(uintptr_t)of_device_get_match_data(dev).
> 

Ok. Let me send out a pile of patches.