linux-kernel - Re: [PATCH 3.16 29/87] staging: iio: cdc: Don't put an else right after a return

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8b056b3df2460d6830a0de97b9cbf3e41d434bbc.camel@decadent.org.uk>
Date:   Thu, 03 Oct 2019 23:06:03 +0100
From:   Ben Hutchings <ben@...adent.org.uk>
To:     Joe Perches <joe@...ches.com>, linux-kernel@...r.kernel.org,
        stable@...r.kernel.org
Cc:     akpm@...ux-foundation.org, Denis Kirjanov <kda@...ux-powerpc.org>,
        Catalina Mocanu <catalina.mocanu@...il.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH 3.16 29/87] staging: iio: cdc: Don't put an else right
 after a return

On Thu, 2019-10-03 at 08:09 -0700, Joe Perches wrote:
> On Thu, 2019-10-03 at 15:47 +0100, Ben Hutchings wrote:
> > On Wed, 2019-10-02 at 14:36 -0700, Joe Perches wrote:
> > > On Wed, 2019-10-02 at 20:06 +0100, Ben Hutchings wrote:
> > > > 3.16.75-rc1 review patch.  If anyone has any objections, please let me know.
> > > 
> > > This doesn't look necessary.
> > 
> > It allows the next patch to apply cleanly.
> 
> Perhaps when you pick patches that are unnecessary
> for any other reason but to allow easier picking of
> actual fixes, the nominal unnecessary patches could
> be marked as necessary for follow-on patches.

I have been doing that lately, but just forgot to do so for this patch.

> Also, when you send these patch series, please use
> an email delay of at least 1 second between each
> entry in the series as the threading is otherwise
> poor in various email clients when sorting by time.

The dates are actually generated before I send them, but I can probably
arrange to override them.  Thanks for the suggestion.

Ben.

-- 
Ben Hutchings
Unix is many things to many people,
but it's never been everything to anybody.



Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)