linux-kernel - RE: [PATCH v6 1/2] drivers: hv: vmbus: Introduce latency testing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CY4PR21MB0136A1ED299DAA92F9301865D79F0@CY4PR21MB0136.namprd21.prod.outlook.com>
Date:   Thu, 3 Oct 2019 23:05:28 +0000
From:   Michael Kelley <mikelley@...rosoft.com>
To:     brandonbonaby94 <brandonbonaby94@...il.com>,
        KY Srinivasan <kys@...rosoft.com>,
        Haiyang Zhang <haiyangz@...rosoft.com>,
        Stephen Hemminger <sthemmin@...rosoft.com>,
        "sashal@...nel.org" <sashal@...nel.org>
CC:     brandonbonaby94 <brandonbonaby94@...il.com>,
        "linux-hyperv@...r.kernel.org" <linux-hyperv@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v6 1/2] drivers: hv: vmbus: Introduce latency testing

From: Branden Bonaby <brandonbonaby94@...il.com> Sent: Thursday, October 3, 2019 2:02 PM
> 
> Introduce user specified latency in the packet reception path
> By exposing the test parameters as part of the debugfs channel
> attributes. We will control the testing state via these attributes.
> 
> Signed-off-by: Branden Bonaby <brandonbonaby94@...il.com>
> ---
> changes in v6:
>  - changed kernel version in
>    Documentation/ABI/testing/debugfs-hyperv to 5.5
> 
>  - removed less than 0 if statement when dealing with
>    u64 datatype, as suggested by Michael.
> 
> changes in v5:
>  - As per Stephen's suggestion, Moved CONFIG_HYPERV_TESTING
>    to lib/Kconfig.debug.
> 
>  - Fixed build issue reported by Kbuild, with Michael's
>    suggestion to make hv_debugfs part of the hv_vmbus
>    module.
> 
>  - updated debugfs-hyperv to show kernel version 5.4
> 
> changes in v4:
>  - Combined v3 patch 2 into this patch, and changed the
>    commit description to reflect this.
> 
>  - Moved debugfs code from "vmbus_drv.c" that was in
>    previous v3 patch 2, into a new file "debugfs.c" in
>    drivers/hv.
> 
>  - Updated the Makefile to compile "debugfs.c" if
>    CONFIG_HYPERV_TESTING is enabled
> 
>  - As per Michael's comments, added empty implementations
>    of the new functions, so the compiler will not generate
>    code when CONFIG_HYPERV_TESTING is not enabled.
> 
>  - Added microseconds into description for files in
>    Documentation/ABI/testing/debugfs-hyperv.
> 
> Changes in v2:
>  - Add #ifdef in Kconfig file so test code will not interfere
>    with non-test code.
>  - Move test code functions for delay to hyperv_vmbus header
>    file.
>  - Wrap test code under #ifdef statement.
> 
>  Documentation/ABI/testing/debugfs-hyperv |  23 +++
>  MAINTAINERS                              |   1 +
>  drivers/hv/Makefile                      |   1 +
>  drivers/hv/connection.c                  |   1 +
>  drivers/hv/hv_debugfs.c                  | 178 +++++++++++++++++++++++
>  drivers/hv/hyperv_vmbus.h                |  31 ++++
>  drivers/hv/ring_buffer.c                 |   2 +
>  drivers/hv/vmbus_drv.c                   |   6 +
>  include/linux/hyperv.h                   |  19 +++
>  lib/Kconfig.debug                        |   7 +
>  10 files changed, 269 insertions(+)
>  create mode 100644 Documentation/ABI/testing/debugfs-hyperv
>  create mode 100644 drivers/hv/hv_debugfs.c
> 

Reviewed-by: Michael Kelley <mikelley@...rosoft.com>