linux-kernel - Re: [RFC PATCH 19/22] thunderbolt: Add support for Time Management Unit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191003080148.GL2819@lahna.fi.intel.com>
Date:   Thu, 3 Oct 2019 11:01:48 +0300
From:   Mika Westerberg <mika.westerberg@...ux.intel.com>
To:     "Mani, Rajmohan" <rajmohan.mani@...el.com>
Cc:     "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        Andreas Noever <andreas.noever@...il.com>,
        "Jamet, Michael" <michael.jamet@...el.com>,
        Yehezkel Bernat <YehezkelShB@...il.com>,
        Nicholas Johnson <nicholas.johnson-opensource@...look.com.au>,
        Lukas Wunner <lukas@...ner.de>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Alan Stern <stern@...land.harvard.edu>,
        "Mario.Limonciello@...l.com" <Mario.Limonciello@...l.com>,
        Anthony Wong <anthony.wong@...onical.com>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [RFC PATCH 19/22] thunderbolt: Add support for Time Management
 Unit

On Wed, Oct 02, 2019 at 04:52:06PM +0000, Mani, Rajmohan wrote:
> > +	/* Enable TMU if it is off */
> > +	if (!tb_switch_tmu_is_enabled(tb->root_switch))
> 
> To be consistent with the implementation of tb_switch_tmu_disable(), should we
> move the above check inside tb_switch_tmu_enable()?

Yes, I think it makes sense.