linux-kernel - Re: [PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future TPM operations

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 3 Oct 2019 14:25:39 +0300
From:   Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
To:     Sasha Levin <sashal@...nel.org>,
        Greg KH <gregkh@...uxfoundation.org>,
        linux-stabley@...r.kernel.org,
        Vadim Sukhomlinov <sukhomlinov@...gle.com>,
        stable@...r.kernel.org, Douglas Anderson <dianders@...omium.org>,
        Peter Huewe <peterhuewe@....de>,
        Jason Gunthorpe <jgunthorpe@...idianresearch.com>,
        "open list:TPM DEVICE DRIVER" <linux-integrity@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 3/3] tpm: Fix TPM 1.2 Shutdown sequence to prevent future
 TPM operations

On Thu, Oct 03, 2019 at 02:24:42PM +0300, Jarkko Sakkinen wrote:
> On Wed, Oct 02, 2019 at 08:42:04AM -0700, Jerry Snitselaar wrote:
> > On Wed Oct 02 19, Jerry Snitselaar wrote:
> > > On Wed Oct 02 19, Sasha Levin wrote:
> > > > On Wed, Oct 02, 2019 at 03:57:58PM +0200, Greg KH wrote:
> > > > > On Wed, Oct 02, 2019 at 04:14:44PM +0300, Jarkko Sakkinen wrote:
> > > > > > From: Vadim Sukhomlinov <sukhomlinov@...gle.com>
> > > > > > 
> > > > > > commit db4d8cb9c9f2af71c4d087817160d866ed572cc9 upstream
> > > > > > 
> > > > > > TPM 2.0 Shutdown involve sending TPM2_Shutdown to TPM chip and disabling
> > > > > > future TPM operations. TPM 1.2 behavior was different, future TPM
> > > > > > operations weren't disabled, causing rare issues. This patch ensures
> > > > > > that future TPM operations are disabled.
> > > > > > 
> > > > > > Fixes: d1bd4a792d39 ("tpm: Issue a TPM2_Shutdown for TPM2 devices.")
> > > > > > Cc: stable@...r.kernel.org
> > > > > > Signed-off-by: Vadim Sukhomlinov <sukhomlinov@...gle.com>
> > > > > > [dianders: resolved merge conflicts with mainline]
> > > > > > Signed-off-by: Douglas Anderson <dianders@...omium.org>
> > > > > > Reviewed-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > > > > > Signed-off-by: Jarkko Sakkinen <jarkko.sakkinen@...ux.intel.com>
> > > > > > ---
> > > > > > drivers/char/tpm/tpm-chip.c | 5 +++--
> > > > > > 1 file changed, 3 insertions(+), 2 deletions(-)
> > > > > 
> > > > > What kernel version(s) is this for?
> > > > 
> > > > It would go to 4.19, we've recently reverted an incorrect backport of
> > > > this patch.
> > > > 
> > > > Jarkko, why is this patch 3/3? We haven't seen the first two on the
> > > > mailing list, do we need anything besides this patch?
> > > > 
> > > > --
> > > > Thanks,
> > > > Sasha
> > > 
> > > It looks like there was a problem mailing the earlier patchset, and patches 1 and 2
> > > weren't cc'd to stable, but patch 3 was.
> > 
> > Is linux-stabley@...r.kernel.org a valid address?
> > 
> 
> No, did a resend :-(

New version sent to stableish@...r.kernel.org.

/Jarkko