linux-kernel - Re: [PATCH v4 2/2] backlight: lm3630a: Add an enable gpio for the HWEN pin

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191003114242.GE21172@dell>
Date:   Thu, 3 Oct 2019 12:42:42 +0100
From:   Lee Jones <lee.jones@...aro.org>
To:     Andreas Kemnade <andreas@...nade.info>
Cc:     daniel.thompson@...aro.org, jingoohan1@...il.com,
        jacek.anaszewski@...il.com, pavel@....cz, dmurphy@...com,
        robh+dt@...nel.org, mark.rutland@....com, b.zolnierkie@...sung.com,
        dri-devel@...ts.freedesktop.org, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-fbdev@...r.kernel.org
Subject: Re: [PATCH v4 2/2] backlight: lm3630a: Add an enable gpio for the
 HWEN pin

On Thu, 12 Sep 2019, Andreas Kemnade wrote:

> For now just enable it in the probe function to allow I2C
> access. Disabling also means resetting the register values
> to default and according to the datasheet does not give
> power savings.
> 
> Tested on Kobo Clara HD.
> 
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> Reviewed-by: Dan Murphy <dmurphy@...com>
> Reviewed-by: Daniel Thompson <daniel.thompson@...aro.org>
> ---
> changes in v2:
> - simplification
> - correct gpio direction initialisation
> 
> changes in v3:
> - removed legacy include
> 
>  drivers/video/backlight/lm3630a_bl.c | 9 +++++++++
>  1 file changed, 9 insertions(+)

Applied, thanks.

-- 
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog