linux-kernel - [PATCH] media: i2c: fix returnvar.cocci warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1910031342250.2406@hadrien>
Date:   Thu, 3 Oct 2019 13:43:37 +0200 (CEST)
From:   Julia Lawall <julia.lawall@...6.fr>
To:     Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
cc:     mchehab@...nel.org, robh+dt@...nel.org, sakari.ailus@....fi,
        linux-media@...r.kernel.org, linux-kernel@...r.kernel.org,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        c.barrett@...mos.com, a.brela@...mos.com,
        Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>,
        kbuild-all@...org
Subject: [PATCH] media: i2c: fix returnvar.cocci warnings

From: kbuild test robot <lkp@...el.com>

Remove unneeded variable used to store return value.

Generated by: scripts/coccinelle/misc/returnvar.cocci

Fixes: a80daf4057d7 ("media: i2c: Add IMX290 CMOS image sensor driver")
CC: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
Signed-off-by: kbuild test robot <lkp@...el.com>
Signed-off-by: Julia Lawall <julia.lawall@...6.fr>
---

url:    https://github.com/0day-ci/linux/commits/Manivannan-Sadhasivam/dt-bindings-media-i2c-Add-IMX290-CMOS-sensor-binding/20191003-175652
base:   git://linuxtv.org/media_tree.git master
:::::: branch date: 2 hours ago
:::::: commit date: 2 hours ago

Please take the patch only if it's a positive warning. Thanks!

 imx290.c |    3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

--- a/drivers/media/i2c/imx290.c
+++ b/drivers/media/i2c/imx290.c
@@ -447,7 +447,6 @@ static int imx290_set_fmt(struct v4l2_su
 	const struct imx290_mode *mode;
 	struct v4l2_mbus_framefmt *format;
 	unsigned int i;
-	int ret = 0;

 	mutex_lock(&imx290->lock);

@@ -483,7 +482,7 @@ static int imx290_set_fmt(struct v4l2_su

 	mutex_unlock(&imx290->lock);

-	return ret;
+	return 0;
 }

 static int imx290_entity_init_cfg(struct v4l2_subdev *subdev,