[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20191003153552.2015-1-anprice@redhat.com>
Date: Thu, 3 Oct 2019 16:35:52 +0100
From: Andrew Price <anprice@...hat.com>
To: cluster-devel@...hat.com
Cc: linux-kernel@...r.kernel.org, syzkaller-bugs@...glegroups.com,
syzbot+c2fdfd2b783754878fb6@...kaller.appspotmail.com
Subject: [PATCH] gfs2: Fix memory leak when gfs2meta's fs_context is freed
gfs2 and gfs2meta share an ->init_fs_context function which allocates an
args structure stored in fc->fs_private. gfs2 registers a ->free
function to free this memory when the fs_context is cleaned up, but
there was not one registered for gfs2meta, causing a leak.
Register a ->free function for gfs2meta. The existing gfs2_fc_free
function does what we need.
Reported-by: syzbot+c2fdfd2b783754878fb6@...kaller.appspotmail.com
Signed-off-by: Andrew Price <anprice@...hat.com>
---
fs/gfs2/ops_fstype.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/fs/gfs2/ops_fstype.c b/fs/gfs2/ops_fstype.c
index 681b44682b0d..dc61af2c4d5e 100644
--- a/fs/gfs2/ops_fstype.c
+++ b/fs/gfs2/ops_fstype.c
@@ -1600,6 +1600,7 @@ static int gfs2_meta_get_tree(struct fs_context *fc)
}
static const struct fs_context_operations gfs2_meta_context_ops = {
+ .free = gfs2_fc_free,
.get_tree = gfs2_meta_get_tree,
};
--
2.21.0
Powered by blists - more mailing lists