linux-kernel - Re: [PATCH V6 5/8] backlight: qcom-wled: Restructure the driver for WLED3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7300c740873439b341d05ee40e071c3f@codeaurora.org>
Date:   Fri, 04 Oct 2019 17:10:55 +0530
From:   kgunda@...eaurora.org
To:     Dan Murphy <dmurphy@...com>
Cc:     bjorn.andersson@...aro.org, jingoohan1@...il.com,
        lee.jones@...aro.org, b.zolnierkie@...sung.com,
        dri-devel@...ts.freedesktop.org, daniel.thompson@...aro.org,
        jacek.anaszewski@...il.com, pavel@....cz, robh+dt@...nel.org,
        mark.rutland@....com, linux-leds@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Andy Gross <agross@...nel.org>, linux-arm-msm@...r.kernel.org,
        linux-fbdev@...r.kernel.org
Subject: Re: [PATCH V6 5/8] backlight: qcom-wled: Restructure the driver for
 WLED3

On 2019-10-01 20:47, Dan Murphy wrote:
> Kiran
> 
> On 9/30/19 1:39 AM, Kiran Gunda wrote:
>> Restructure the driver to add the support for new WLED
>> peripherals.
>> 
>> Signed-off-by: Kiran Gunda <kgunda@...eaurora.org>
>> Acked-by: Daniel Thompson <daniel.thompson@...aro.org>
>> ---
>>   drivers/video/backlight/qcom-wled.c | 395 
>> ++++++++++++++++++++++--------------
>>   1 file changed, 245 insertions(+), 150 deletions(-)
>> 
>> diff --git a/drivers/video/backlight/qcom-wled.c 
>> b/drivers/video/backlight/qcom-wled.c
>> index f191242..740f1b6 100644
>> --- a/drivers/video/backlight/qcom-wled.c
>> +++ b/drivers/video/backlight/qcom-wled.c
>> @@ -7,59 +7,71 @@
>>   #include <linux/module.h>
>>   #include <linux/of.h>
>>   #include <linux/of_device.h>
>> +#include <linux/of_address.h>
>>   #include <linux/regmap.h>
>>     /* From DT binding */
>> +#define WLED_MAX_STRINGS				4
>> +
>>   #define WLED_DEFAULT_BRIGHTNESS				2048
>>   -#define WLED3_SINK_REG_BRIGHT_MAX			0xFFF
>> -#define WLED3_CTRL_REG_VAL_BASE				0x40
>> +#define WLED_SINK_REG_BRIGHT_MAX			0xFFF
> 
> Why did you change some of these again?
> 
> Can you just change it to the final #define in patch 4/8?
> 
> Dan
> 
> <snip>
Ok.. Looks like some thing went wrong with this series. I will re-upload 
it again.