linux-kernel - Re: [PATCH 1/2] usb: support suspend

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191004115843.GA339043@kroah.com>
Date:   Fri, 4 Oct 2019 13:58:43 +0200
From:   Greg Kroah-Hartman <gregkh@...uxfoundation.org>
To:     Abhishek Pandit-Subedi <abhishekpandit@...omium.org>
Cc:     linux-bluetooth@...r.kernel.org, linux-usb@...r.kernel.org,
        dianders@...omium.org, Kai-Heng Feng <kai.heng.feng@...onical.com>,
        Alan Stern <stern@...land.harvard.edu>,
        Hui Peng <benquike@...il.com>, linux-pm@...r.kernel.org,
        Suzuki K Poulose <suzuki.poulose@....com>,
        Mark Brown <broonie@...nel.org>,
        "Rafael J. Wysocki" <rjw@...ysocki.net>,
        Wolfram Sang <wsa@...-dreams.de>, linux-kernel@...r.kernel.org,
        Len Brown <len.brown@...el.com>,
        Mathias Payer <mathias.payer@...elwelt.net>,
        Dmitry Torokhov <dtor@...omium.org>,
        Mans Rullgard <mans@...sr.com>, Pavel Machek <pavel@....cz>,
        YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH 1/2] usb: support suspend_noirq

On Tue, Sep 17, 2019 at 02:27:01PM -0700, Abhishek Pandit-Subedi wrote:
> If we put a usb device into reset in the suspend callback, it will
> disconnect and the resume will not be called. In order to support
> turning off the device on suspend and restoring it on resume, we must do
> the reset action in suspend_noirq.

That's a bit odd given that USB drivers/devices _require_ irqs to be
enabled in order to talk to them and work properly.

So I don't see how this works at all, nor how any USB driver could even
use this.

greg k-h