linux-kernel - Re: [PATCH] ARM: dts: stm32: add focaltech touchscreen on stm32mp157c-dk2 board

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c0d6de33-38fa-b55e-20cb-e5b680a35dfb@st.com>
Date:   Fri, 4 Oct 2019 13:21:04 +0000
From:   Yannick FERTRE <yannick.fertre@...com>
To:     Alexandre TORGUE <alexandre.torgue@...com>,
        Maxime Coquelin <mcoquelin.stm32@...il.com>,
        Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        "linux-stm32@...md-mailman.stormreply.com" 
        <linux-stm32@...md-mailman.stormreply.com>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Benjamin GAIGNARD <benjamin.gaignard@...com>,
        Philippe CORNU <philippe.cornu@...com>,
        Fabrice GASNIER <fabrice.gasnier@...com>
Subject: Re: [PATCH] ARM: dts: stm32: add focaltech touchscreen on
 stm32mp157c-dk2 board

Hi Alex,

ok, i'll push only the dt patch link to the last version of driver 
touchscreen on display board MB1407.

BR

Yannick Fertré


On 10/3/19 12:34 PM, Alexandre Torgue wrote:
> Hi Yannick
>
> On 9/30/19 4:45 PM, Yannick Fertré wrote:
>> Enable focaltech ft6236 touchscreen on STM32MP157C-DK2 board.
>> This device supports 2 different addresses (0x2a and 0x38)
>> depending on the display  board version (MB1407).
>>
>> Signed-off-by: Yannick Fertré <yannick.fertre@...com>
>> ---
>>   arch/arm/boot/dts/stm32mp157c-dk2.dts | 23 +++++++++++++++++++++++
>>   1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm/boot/dts/stm32mp157c-dk2.dts 
>> b/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> index 20ea601..527bb75 100644
>> --- a/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> +++ b/arch/arm/boot/dts/stm32mp157c-dk2.dts
>> @@ -61,6 +61,29 @@
>>       };
>>   };
>>   +&i2c1 {
>> +    touchscreen@2a {
>> +        compatible = "focaltech,ft6236";
>> +        reg = <0x2a>;
>> +        interrupts = <2 2>;
>> +        interrupt-parent = <&gpiof>;
>> +        interrupt-controller;
>> +        touchscreen-size-x = <480>;
>> +        touchscreen-size-y = <800>;
>> +        status = "okay";
>> +    };
>> +    touchscreen@38 {
>> +        compatible = "focaltech,ft6236";
>> +        reg = <0x38>;
>> +        interrupts = <2 2>;
>> +        interrupt-parent = <&gpiof>;
>> +        interrupt-controller;
>> +        touchscreen-size-x = <480>;
>> +        touchscreen-size-y = <800>;
>> +        status = "okay";
>> +    };
>> +};
>
> I'm not confident by this duplication. We should only support the 
> latest revision of the MB1407. I understand the need but my fear is to 
> duplicate this node each time we have a new revision (and imagine if 
> we do that for all i2c devices).
>
> regards
> alex
>
>
>>   &ltdc {
>>       status = "okay";