linux-kernel - Re: [PATCH 4.19 090/211] media: mceusb: fix (eliminate) TX IR signal length limit

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191004134732.GG17454@sasha-vm>
Date:   Fri, 4 Oct 2019 09:47:32 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Pavel Machek <pavel@...x.de>
Cc:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        A Sun <as1033x@...cast.net>, Sean Young <sean@...s.org>,
        Mauro Carvalho Chehab <mchehab+samsung@...nel.org>
Subject: Re: [PATCH 4.19 090/211] media: mceusb: fix (eliminate) TX IR signal
 length limit

On Fri, Oct 04, 2019 at 12:12:15PM +0200, Pavel Machek wrote:
>On Thu 2019-10-03 17:52:36, Greg Kroah-Hartman wrote:
>> From: A Sun <as1033x@...cast.net>
>
>> Other changes:
>>
>> The driver's write to USB device architecture change (async to sync I/O)
>> is significant so we bump DRIVER_VERSION to "1.95" (from "1.94").
>
>> ---
>>  drivers/media/rc/mceusb.c | 334 ++++++++++++++++++++++----------------
>>  1 file changed, 196 insertions(+), 138 deletions(-)
>
>This is not a bugfix, this is rewrite that happens to remove a
>limitation, and it is way over the 100 line limit. What is going on
>here? Why is it even considered for stable?

It's on the bigger side, sure, but it's contained inside a driver and
seems to fix an actual issue.

--
Thanks,
Sasha