linux-kernel - Re: KASAN: use-after-free Read in rxrpc_release

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <17922.1570200004@warthog.procyon.org.uk>
Date:   Fri, 04 Oct 2019 15:40:04 +0100
From:   David Howells <dhowells@...hat.com>
To:     Hillf Danton <hdanton@...a.com>
Cc:     dhowells@...hat.com,
        syzbot <syzbot+eed305768ece6682bb7f@...kaller.appspotmail.com>,
        davem@...emloft.net, linux-afs@...ts.infradead.org,
        linux-kernel@...r.kernel.org, netdev@...r.kernel.org,
        syzkaller-bugs@...glegroups.com
Subject: Re: KASAN: use-after-free Read in rxrpc_release_call

Hillf Danton <hdanton@...a.com> wrote:

>  	if (conn) {
> -		rxrpc_disconnect_call(call);
>  		conn->security->free_call_crypto(call);
> +		rxrpc_disconnect_call(call);
>  	}

Better to cache the security pointer in the call struct, I think.

David