linux-kernel - Re: [PATCH] serial: move Non-standard serial drivers menu to the Serial drivers menu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 4 Oct 2019 07:58:40 -0700
From:   Randy Dunlap <rdunlap@...radead.org>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc:     LKML <linux-kernel@...r.kernel.org>,
        "open list:SERIAL DRIVERS" <linux-serial@...r.kernel.org>
Subject: Re: [PATCH] serial: move Non-standard serial drivers menu to the
 Serial drivers menu

On 10/4/19 5:54 AM, Greg Kroah-Hartman wrote:
> On Wed, Sep 25, 2019 at 06:16:28PM -0700, Randy Dunlap wrote:
>> From: Randy Dunlap <rdunlap@...radead.org>
>>
>> Since Non-standard serial port drivers are also Serial drivers,
>> move the "Non-standard serial port support" menu to be under/in
>> the "Serial drivers" menu. With this move, the "Serial drivers"
>> menu contains (a) 8250/16550 support, (b) non-8250 support, and
>> (c) non-standard serial port support.
>>
>> Signed-off-by: Randy Dunlap <rdunlap@...radead.org>
>> ---
>>  drivers/tty/Kconfig        |  119 -----------------------------------
>>  drivers/tty/serial/Kconfig |  119 +++++++++++++++++++++++++++++++++++
>>  2 files changed, 119 insertions(+), 119 deletions(-)
>>
>> --- lnx-53.orig/drivers/tty/Kconfig
>> +++ lnx-53/drivers/tty/Kconfig
>> @@ -151,125 +151,6 @@ config LEGACY_PTY_COUNT
>>  	  When not in use, each legacy PTY occupies 12 bytes on 32-bit
>>  	  architectures and 24 bytes on 64-bit architectures.
>>  
>> -config SERIAL_NONSTANDARD
>> -	bool "Non-standard serial port support"
>> -	depends on HAS_IOMEM
>> -	---help---
>> -	  Say Y here if you have any non-standard serial boards -- boards
>> -	  which aren't supported using the standard "dumb" serial driver.
>> -	  This includes intelligent serial boards such as Cyclades,
>> -	  Digiboards, etc. These are usually used for systems that need many
>> -	  serial ports because they serve many terminals or dial-in
>> -	  connections.
>> -
>> -	  Note that the answer to this question won't directly affect the
>> -	  kernel: saying N will just cause the configurator to skip all
>> -	  the questions about non-standard serial boards.
>> -
>> -	  Most people can say N here.
>> -
>> -config ROCKETPORT
>> -	tristate "Comtrol RocketPort support"
>> -	depends on SERIAL_NONSTANDARD && (ISA || EISA || PCI)
> 
> I would agree with the move, but the files are not in
> drivers/tty/serial/ for the drivers you are asking to configure in that
> directory.
> 
> So unless we want to move these drivers (and it's not really worth it,
> unless we want to create drivers/tty/serial/obsolete/ or something like
> that), I would just leave this alone.

ack that.  Thanks.

-- 
~Randy