linux-kernel - Re: [PATCH] drm/i810: Prevent underflow in ioctl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <157020508581.18712.9108329337994387428@skylake-alporthouse-com>
Date:   Fri, 04 Oct 2019 17:04:45 +0100
From:   Chris Wilson <chris@...is-wilson.co.uk>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        David Airlie <airlied@...ux.ie>
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org,
        dri-devel@...ts.freedesktop.org, Sam Ravnborg <sam@...nborg.org>,
        Emil Velikov <emil.velikov@...labora.com>
Subject: Re: [PATCH] drm/i810: Prevent underflow in ioctl

Quoting Chris Wilson (2019-10-04 15:08:57)
> Quoting Dan Carpenter (2019-10-04 11:22:51)
> > The "used" variables here come from the user in the ioctl and it can be
> > negative.  It could result in an out of bounds write.
> > 
> > Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>
> > ---
> >  drivers/gpu/drm/i810/i810_dma.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/drivers/gpu/drm/i810/i810_dma.c b/drivers/gpu/drm/i810/i810_dma.c
> > index 2a77823b8e9a..e66c38332df4 100644
> > --- a/drivers/gpu/drm/i810/i810_dma.c
> > +++ b/drivers/gpu/drm/i810/i810_dma.c
> > @@ -728,7 +728,7 @@ static void i810_dma_dispatch_vertex(struct drm_device *dev,
> >         if (nbox > I810_NR_SAREA_CLIPRECTS)
> >                 nbox = I810_NR_SAREA_CLIPRECTS;
> >  
> > -       if (used > 4 * 1024)
> > +       if (used < 0 || used > 4 * 1024)
> >                 used = 0;
> 
> Yes, as passed to the GPU instruction, negative used is invalid.
> 
> Then it is used as an offset into a memblock, where a negative offset
> would be very bad.
> 
> Reviewed-by: Chris Wilson <chris@...is-wilson.co.uk>

Applied to drm-misc-next with cc'ed stable.
-Chris