linux-kernel - Re: [PATCH v3 2/5] dt-bindings: mfd: Document the Xylon LogiCVC multi-function device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAL_Jsq+J9z3zzENZxXwjjsVMbFr8uYpXX6jYbCqdQEKBQXOu9A@mail.gmail.com>
Date:   Fri, 4 Oct 2019 11:09:00 -0500
From:   Rob Herring <robh@...nel.org>
To:     Lee Jones <lee.jones@...aro.org>
Cc:     Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        devicetree@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        Linus Walleij <linus.walleij@...aro.org>,
        Bartosz Golaszewski <bgolaszewski@...libre.com>,
        Mark Rutland <mark.rutland@....com>,
        Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH v3 2/5] dt-bindings: mfd: Document the Xylon LogiCVC
 multi-function device

On Fri, Oct 4, 2019 at 9:45 AM Lee Jones <lee.jones@...aro.org> wrote:
>
> On Fri, 27 Sep 2019, Rob Herring wrote:
>
> > On Fri, Sep 27, 2019 at 12:04:04PM +0200, Paul Kocialkowski wrote:
> > > The LogiCVC is a display engine which also exposes GPIO functionality.
> > > For this reason, it is described as a multi-function device that is expected
> > > to provide register access to its children nodes for gpio and display.
> > >
> > > Signed-off-by: Paul Kocialkowski <paul.kocialkowski@...tlin.com>
> > > ---
> > >  .../bindings/mfd/xylon,logicvc.yaml           | 50 +++++++++++++++++++
> > >  1 file changed, 50 insertions(+)
> > >  create mode 100644 Documentation/devicetree/bindings/mfd/xylon,logicvc.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/mfd/xylon,logicvc.yaml b/Documentation/devicetree/bindings/mfd/xylon,logicvc.yaml
> > > new file mode 100644
> > > index 000000000000..abc9937506e0
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/mfd/xylon,logicvc.yaml
> > > @@ -0,0 +1,50 @@
> > > +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> > > +# Copyright 2019 Bootlin
> > > +%YAML 1.2
> > > +---
> > > +$id: "http://devicetree.org/schemas/mfd/xylon,logicvc.yaml#"
> > > +$schema: "http://devicetree.org/meta-schemas/core.yaml#"
> > > +
> > > +title: Xylon LogiCVC multi-function device
> > > +
> > > +maintainers:
> > > +  - Paul Kocialkowski <paul.kocialkowski@...tlin.com>
> > > +
> > > +description: |
> > > +  The LogiCVC is a display controller that also contains a GPIO controller.
> > > +  As a result, a multi-function device is exposed as parent of the display
> > > +  and GPIO blocks.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    items:
> > > +      - enum:
> > > +          - xylon,logicvc-3.02.a
> > > +      - const: syscon
> > > +      - const: simple-mfd
> > > +
> > > +  reg:
> > > +    maxItems: 1
> > > +
> > > +select:
> > > +  properties:
> > > +    compatible:
> > > +      contains:
> > > +        enum:
> > > +          - xylon,logicvc-3.02.a
> >
> > I've seen a couple of these with 'syscon' today, so I fixed the schema
> > tool to just exclude 'syscon' and 'simple-mfd' from the generated
> > 'select'. So you can drop select now.
>
> Does this need to happen before this patch can be applied?

Drop the 'select'? Yes that should happen first.

Rob