linux-kernel - Re: [PATCH v7 3/5] mfd: ioc3: Add driver for SGI IOC3 chip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Fri, 4 Oct 2019 19:25:09 +0200
From:   Thomas Bogendoerfer <tbogendoerfer@...e.de>
To:     "David S. Miller" <davem@...emloft.net>
Cc:     Jonathan Corbet <corbet@....net>,
        Ralf Baechle <ralf@...ux-mips.org>,
        Paul Burton <paul.burton@...s.com>,
        James Hogan <jhogan@...nel.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Jiri Slaby <jslaby@...e.com>, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-mips@...r.kernel.org,
        netdev@...r.kernel.org, linux-rtc@...r.kernel.org,
        linux-serial@...r.kernel.org, Lee Jones <lee.jones@...aro.org>
Subject: Re: [PATCH v7 3/5] mfd: ioc3: Add driver for SGI IOC3 chip

On Fri, 4 Oct 2019 15:44:53 +0100
Lee Jones <lee.jones@...aro.org> wrote:

> On Thu, 03 Oct 2019, Thomas Bogendoerfer wrote:
> > +	if (mask & BIT(IOC3_IRQ_ETH_DOMAIN))
> > +		/* if eth irq is enabled we need to check in eth irq regs */
> 
> Nit: Comments should be expressive.  Please expand all of the
> short-hand in this sentence.  It would also be nicer if you started
> with an uppercase character.
> 
> Same with all of the other comments in this file.

ok.

> Other than that, it looks like it's really coming together.  Once the
> above is fixed, please re-sumbit with my:

Thanks.

David, 

before re-posting with the english grammer pimp up, is there anything
I should improve for the network part ? If not, could I get a acked-by
from your side ?

Thomas.

-- 
SUSE Software Solutions Germany GmbH
HRB 247165 (AG München)
Geschäftsführer: Felix Imendörffer