linux-kernel - Re: [PATCH] Remove GP_REPLAY state from rcu

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201910050359.ElTc0vbc%lkp@intel.com>
Date:   Sat, 5 Oct 2019 03:25:59 +0800
From:   kbuild test robot <lkp@...el.com>
To:     "Joel Fernandes (Google)" <joel@...lfernandes.org>
Cc:     kbuild-all@...org, linux-kernel@...r.kernel.org,
        Joel Fernandes <joel@...lfernandes.org>, bristot@...hat.com,
        peterz@...radead.org, oleg@...hat.com, paulmck@...nel.org,
        rcu@...r.kernel.org, Josh Triplett <josh@...htriplett.org>,
        Lai Jiangshan <jiangshanlai@...il.com>,
        Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
        "Paul E. McKenney" <paulmck@...ux.ibm.com>,
        Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] Remove GP_REPLAY state from rcu_sync

Hi "Joel,

I love your patch! Yet something to improve:

[auto build test ERROR on rcu/dev]
[cannot apply to v5.4-rc1 next-20191004]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/Joel-Fernandes-Google/Remove-GP_REPLAY-state-from-rcu_sync/20191005-024257
base:   https://git.kernel.org/pub/scm/linux/kernel/git/paulmck/linux-rcu.git dev
config: i386-tinyconfig (attached as .config)
compiler: gcc-7 (Debian 7.4.0-13) 7.4.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   kernel/rcu/sync.c: In function 'rcu_sync_dtor':
>> kernel/rcu/sync.c:187:23: error: 'GP_REPLAY' undeclared (first use in this function)
     if (rsp->gp_state == GP_REPLAY)
                          ^~~~~~~~~
   kernel/rcu/sync.c:187:23: note: each undeclared identifier is reported only once for each function it appears in

vim +/GP_REPLAY +187 kernel/rcu/sync.c

07899a6e5f5613 Oleg Nesterov 2015-08-21  174  
07899a6e5f5613 Oleg Nesterov 2015-08-21  175  /**
07899a6e5f5613 Oleg Nesterov 2015-08-21  176   * rcu_sync_dtor() - Clean up an rcu_sync structure
07899a6e5f5613 Oleg Nesterov 2015-08-21  177   * @rsp: Pointer to rcu_sync structure to be cleaned up
07899a6e5f5613 Oleg Nesterov 2015-08-21  178   */
07899a6e5f5613 Oleg Nesterov 2015-08-21  179  void rcu_sync_dtor(struct rcu_sync *rsp)
07899a6e5f5613 Oleg Nesterov 2015-08-21  180  {
89da3b94bb9741 Oleg Nesterov 2019-04-25  181  	int gp_state;
07899a6e5f5613 Oleg Nesterov 2015-08-21  182  
89da3b94bb9741 Oleg Nesterov 2019-04-25  183  	WARN_ON_ONCE(READ_ONCE(rsp->gp_count));
89da3b94bb9741 Oleg Nesterov 2019-04-25  184  	WARN_ON_ONCE(READ_ONCE(rsp->gp_state) == GP_PASSED);
07899a6e5f5613 Oleg Nesterov 2015-08-21  185  
07899a6e5f5613 Oleg Nesterov 2015-08-21  186  	spin_lock_irq(&rsp->rss_lock);
89da3b94bb9741 Oleg Nesterov 2019-04-25 @187  	if (rsp->gp_state == GP_REPLAY)

:::::: The code at line 187 was first introduced by commit
:::::: 89da3b94bb97417ca2c5b0ce3a28643819030247 rcu/sync: Simplify the state machine

:::::: TO: Oleg Nesterov <oleg@...hat.com>
:::::: CC: Paul E. McKenney <paulmck@...ux.ibm.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (7205 bytes)