linux-kernel - Re: [PATCH] pinctl: ti: iodelay: fix error checking on pinctrl_count_index_with

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACRpkdbQBaZgYBGAAfi7mg+4RMfWovi9io28q4u7KAW44bJ6WQ@mail.gmail.com>
Date:   Fri, 4 Oct 2019 23:09:33 +0200
From:   Linus Walleij <linus.walleij@...aro.org>
To:     Colin King <colin.king@...onical.com>
Cc:     Tony Lindgren <tony@...mide.com>,
        YueHaibing <yuehaibing@...wei.com>, Nishanth Menon <nm@...com>,
        Tero Kristo <t-kristo@...com>,
        "open list:GPIO SUBSYSTEM" <linux-gpio@...r.kernel.org>,
        kernel-janitors@...r.kernel.org,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] pinctl: ti: iodelay: fix error checking on
 pinctrl_count_index_with_args call

On Fri, Sep 20, 2019 at 2:20 PM Colin King <colin.king@...onical.com> wrote:

> From: Colin Ian King <colin.king@...onical.com>
>
> The call to pinctrl_count_index_with_args checks for a -EINVAL return
> however this function calls pinctrl_get_list_and_count and this can
> return -ENOENT. Rather than check for a specific error, fix this by
> checking for any error return to catch the -ENOENT case.
>
> Addresses-Coverity: ("Improper use of negative")
> Fixes: 003910ebc83b ("pinctrl: Introduce TI IOdelay configuration driver")
> Signed-off-by: Colin Ian King <colin.king@...onical.com>

Patch applied with Tony's ACK.

Yours,
Linus Walleij