linux-kernel - Re: [PATCH -next 09/15] thermal: rockchip: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <6308452.QoXZFhLlpT@phil>
Date:   Fri, 04 Oct 2019 23:49:47 +0200
From:   Heiko Stuebner <heiko@...ech.de>
To:     YueHaibing <yuehaibing@...wei.com>
Cc:     miquel.raynal@...tlin.com, rui.zhang@...el.com,
        edubezval@...il.com, daniel.lezcano@...aro.org,
        amit.kucheria@...durent.com, eric@...olt.net, wahrenst@....net,
        f.fainelli@...il.com, rjui@...adcom.com, sbranden@...adcom.com,
        mmayer@...adcom.com, computersforpeace@...il.com,
        gregory.0xf0@...il.com, matthias.bgg@...il.com, agross@...nel.org,
        mcoquelin.stm32@...il.com, alexandre.torgue@...com,
        marc.w.gonzalez@...e.fr, mans@...sr.com, talel@...zon.com,
        jun.nie@...aro.org, shawnguo@...nel.org, phil@...pberrypi.org,
        gregkh@...uxfoundation.org, david.hernandezsanchez@...com,
        horms+renesas@...ge.net.au, wsa+renesas@...g-engineering.com,
        bcm-kernel-feedback-list@...adcom.com, linux-pm@...r.kernel.org,
        linux-kernel@...r.kernel.org, linux-rpi-kernel@...ts.infradead.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org, linux-arm-msm@...r.kernel.org,
        linux-rockchip@...ts.infradead.org,
        linux-stm32@...md-mailman.stormreply.com
Subject: Re: [PATCH -next 09/15] thermal: rockchip: use devm_platform_ioremap_resource() to simplify code

Am Mittwoch, 4. September 2019, 14:29:33 CEST schrieb YueHaibing:
> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Heiko Stuebner <heiko@...ech.de>

> ---
>  drivers/thermal/rockchip_thermal.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/thermal/rockchip_thermal.c b/drivers/thermal/rockchip_thermal.c
> index 343c2f5..044e6eb 100644
> --- a/drivers/thermal/rockchip_thermal.c
> +++ b/drivers/thermal/rockchip_thermal.c
> @@ -1219,7 +1219,6 @@ static int rockchip_thermal_probe(struct platform_device *pdev)
>  	struct device_node *np = pdev->dev.of_node;
>  	struct rockchip_thermal_data *thermal;
>  	const struct of_device_id *match;
> -	struct resource *res;
>  	int irq;
>  	int i;
>  	int error;
> @@ -1245,8 +1244,7 @@ static int rockchip_thermal_probe(struct platform_device *pdev)
>  	if (!thermal->chip)
>  		return -EINVAL;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	thermal->regs = devm_ioremap_resource(&pdev->dev, res);
> +	thermal->regs = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(thermal->regs))
>  		return PTR_ERR(thermal->regs);
>  
>