linux-kernel - Re: BISECTED: Compile error on 5.4-rc1

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0259e98-225c-58f8-1640-04322c621690@skogtun.org>
Date:   Sat, 5 Oct 2019 12:50:22 +0200
From:   Harald Arnesen <harald@...gtun.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: BISECTED: Compile error on 5.4-rc1

Masahiro Yamada [05.10.2019 12:19]:

> CONFIG_SHELL previously fell back to 'sh' when bash is not installed,
> so I just kept it as it was.
> 
> If we had used the exact absolute path /bin/sh,
> it would have worked irrespective of the PATH environment.
> 
> But, there is a counter option like this:
> 
> 
> commit 16f8259ca77d04f95e5ca90be1b1894ed45816c0
> Author: Bjørn Forsman <bjorn.forsman@...il.com>
> Date:   Sun Nov 5 10:44:16 2017 +0100
> 
>     kbuild: /bin/pwd -> pwd
> 
>     Most places use pwd and rely on $PATH lookup. Moving the remaining
>     absolute path /bin/pwd users over for consistency.
> 
>     Also, a reason for doing /bin/pwd -> pwd instead of the other way around
>     is because I believe build systems should make little assumptions on
>     host filesystem layout. Case in point, we do this kind of patching
>     already in NixOS.
> 
>     Ref. commit 028568d84da3cfca49f5f846eeeef01441d70451
>     ("kbuild: revert $(realpath ...) to $(shell cd ... && /bin/pwd)").
> 
>     Signed-off-by: Bjørn Forsman <bjorn.forsman@...il.com>
>     Signed-off-by: Masahiro Yamada <yamada.masahiro@...ionext.com>
> 
> 
> 
> I cannot find a way to satisfy everybody.
> 

I'm totally fine with the way it is now, now that I know how it works.
However, doesn't Posix dictate that there is a /bin/sh?
-- 
Hilsen Harald