linux-kernel - Re: [PATCH] drm/amdkfd: add missing void argument to function kgd2kfd

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d9ae3586-f484-9734-1cc7-5e960fde76a3@canonical.com>
Date:   Sat, 5 Oct 2019 19:23:05 +0100
From:   Colin Ian King <colin.king@...onical.com>
To:     Randy Dunlap <rdunlap@...radead.org>,
        Felix Kuehling <Felix.Kuehling@....com>,
        Alex Deucher <alexander.deucher@....com>,
        Christian König <christian.koenig@....com>,
        David Zhou <David1.Zhou@....com>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>, amd-gfx@...ts.freedesktop.org,
        dri-devel@...ts.freedesktop.org
Cc:     kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] drm/amdkfd: add missing void argument to function
 kgd2kfd_init

On 05/10/2019 19:10, Randy Dunlap wrote:
> On 10/5/19 10:58 AM, Colin King wrote:
>> From: Colin Ian King <colin.king@...onical.com>
>>
>> Function kgd2kfd_init is missing a void argument, add it
>> to clean up the non-ANSI function declaration.
>>
>> Signed-off-by: Colin Ian King <colin.king@...onical.com>
> 
> Acked-by: Randy Dunlap <rdunlap@...radead.org>
> 
> sparse reports 2 such warnings in amdgpu:
> 
> ../drivers/gpu/drm/amd/amdgpu/../amdkfd/kfd_module.c:85:18: warning: non-ANSI function declaration of function 'kgd2kfd_init'
> ../drivers/gpu/drm/amd/amdgpu/amdgpu_amdkfd_gfx_v10.c:168:60: warning: non-ANSI function declaration of function 'amdgpu_amdkfd_gfx_10_0_get_functions'

Looking at linux-next, the amdgpu_amdkfd_gfx_10_0_get_functions() was
removed in commit:

commit e392c887df979112af94cfec08dd87f4dd55d085
Author: Yong Zhao <Yong.Zhao@....com>
Date:   Fri Sep 27 22:03:42 2019 -0400

    drm/amdkfd: Use array to probe kfd2kgd_calls

..so I didn't fix that one up

Coln
> 
> Thanks.
> 
>> ---
>>  drivers/gpu/drm/amd/amdkfd/kfd_module.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_module.c b/drivers/gpu/drm/amd/amdkfd/kfd_module.c
>> index 986ff52d5750..f4b7f7e6c40e 100644
>> --- a/drivers/gpu/drm/amd/amdkfd/kfd_module.c
>> +++ b/drivers/gpu/drm/amd/amdkfd/kfd_module.c
>> @@ -82,7 +82,7 @@ static void kfd_exit(void)
>>  	kfd_chardev_exit();
>>  }
>>  
>> -int kgd2kfd_init()
>> +int kgd2kfd_init(void)
>>  {
>>  	return kfd_init();
>>  }
>>
> 
>