linux-kernel - Re: [PATCH AUTOSEL 5.3 20/49] firmware: bcm47xx_nvram: Correct size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Sat, 5 Oct 2019 18:53:05 -0400
From:   Sasha Levin <sashal@...nel.org>
To:     Florian Fainelli <f.fainelli@...il.com>
Cc:     linux-kernel@...r.kernel.org, stable@...r.kernel.org,
        Philippe Mathieu-Daudé <f4bug@...at.org>,
        Paul Burton <paul.burton@...s.com>, linux-mips@...ux-mips.org,
        joe@...ches.com,
        Rafał Miłecki <zajec5@...il.com>,
        linux-mips@...r.kernel.org
Subject: Re: [PATCH AUTOSEL 5.3 20/49] firmware: bcm47xx_nvram: Correct
 size_t printf format

On Sun, Sep 29, 2019 at 12:39:05PM -0700, Florian Fainelli wrote:
>
>
>On 9/29/2019 10:30 AM, Sasha Levin wrote:
>> From: Florian Fainelli <f.fainelli@...il.com>
>>
>> [ Upstream commit feb4eb060c3aecc3c5076bebe699cd09f1133c41 ]
>>
>> When building on a 64-bit host, we will get warnings like those:
>>
>> drivers/firmware/broadcom/bcm47xx_nvram.c:103:3: note: in expansion of macro 'pr_err'
>>    pr_err("nvram on flash (%i bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
>>    ^~~~~~
>> drivers/firmware/broadcom/bcm47xx_nvram.c:103:28: note: format string is defined here
>>    pr_err("nvram on flash (%i bytes) is bigger than the reserved space in memory, will just copy the first %i bytes\n",
>>                            ~^
>>                            %li
>>
>> Use %zu instead for that purpose.
>
>This is not a fix that should be backported as it was done only to allow
>the driver to the made buildable with COMPILE_TEST. Please drop it from
>your auto-selection.

Now dropped, thank you!

-- 
Thanks,
Sasha