linux-kernel - Re: [PATCH v15 13/14] gpio: max3191x: Utilize the for_each_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201910060744.lgRuOOiw%lkp@intel.com>
Date:   Sun, 6 Oct 2019 07:26:10 +0800
From:   kbuild test robot <lkp@...el.com>
To:     William Breathitt Gray <vilhelm.gray@...il.com>
Cc:     kbuild-all@...org, linus.walleij@...aro.org,
        bgolaszewski@...libre.com, akpm@...ux-foundation.org,
        linux-gpio@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arch@...r.kernel.org, andriy.shevchenko@...ux.intel.com,
        linux@...musvillemoes.dk, yamada.masahiro@...ionext.com,
        linux-arm-kernel@...ts.infradead.org, linux-pm@...r.kernel.org,
        geert@...ux-m68k.org, preid@...ctromag.com.au, lukas@...ner.de,
        sean.nyekjaer@...vas.dk, morten.tiljeset@...vas.dk,
        William Breathitt Gray <vilhelm.gray@...il.com>,
        Mathias Duckeck <m.duckeck@...bus.de>
Subject: Re: [PATCH v15 13/14] gpio: max3191x: Utilize the
 for_each_set_clump8 macro

Hi William,

I love your patch! Yet something to improve:

[auto build test ERROR on gpio/for-next]
[cannot apply to v5.4-rc1 next-20191004]
[if your patch is applied to the wrong git tree, please drop us a note to help
improve the system. BTW, we also suggest to use '--base' option to specify the
base tree in git format-patch, please see https://stackoverflow.com/a/37406982]

url:    https://github.com/0day-ci/linux/commits/William-Breathitt-Gray/Introduce-the-for_each_set_clump8-macro/20191006-032112
base:   https://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git for-next
config: ia64-allmodconfig (attached as .config)
compiler: ia64-linux-gcc (GCC) 7.4.0
reproduce:
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        GCC_VERSION=7.4.0 make.cross ARCH=ia64 

If you fix the issue, kindly add following tag
Reported-by: kbuild test robot <lkp@...el.com>

All errors (new ones prefixed by >>):

   drivers/gpio/gpio-max3191x.c: In function 'max3191x_get_multiple':
>> drivers/gpio/gpio-max3191x.c:258:31: error: 'offset' undeclared (first use in this function); did you mean 'off_t'?
      bitmap_set_value8(bits, in, offset);
                                  ^~~~~~
                                  off_t
   drivers/gpio/gpio-max3191x.c:258:31: note: each undeclared identifier is reported only once for each function it appears in

vim +258 drivers/gpio/gpio-max3191x.c

   231	
   232	static int max3191x_get_multiple(struct gpio_chip *gpio, unsigned long *mask,
   233					 unsigned long *bits)
   234	{
   235		struct max3191x_chip *max3191x = gpiochip_get_data(gpio);
   236		const unsigned int wordlen = max3191x_wordlen(max3191x);
   237		int ret;
   238		unsigned long bit;
   239		unsigned long gpio_mask;
   240		unsigned long in;
   241	
   242		mutex_lock(&max3191x->lock);
   243		ret = max3191x_readout_locked(max3191x);
   244		if (ret)
   245			goto out_unlock;
   246	
   247		bitmap_zero(bits, gpio->ngpio);
   248		for_each_set_clump8(bit, gpio_mask, mask, gpio->ngpio) {
   249			unsigned int chipnum = bit / MAX3191X_NGPIO;
   250	
   251			if (max3191x_chip_is_faulting(max3191x, chipnum)) {
   252				ret = -EIO;
   253				goto out_unlock;
   254			}
   255	
   256			in = ((u8 *)max3191x->xfer.rx_buf)[chipnum * wordlen];
   257			in &= gpio_mask;
 > 258			bitmap_set_value8(bits, in, offset);
   259		}
   260	
   261	out_unlock:
   262		mutex_unlock(&max3191x->lock);
   263		return ret;
   264	}
   265	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (54933 bytes)