lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sat, 5 Oct 2019 10:40:33 +0200 From: Christoph Hellwig <hch@....de> To: Kees Cook <keescook@...omium.org> Cc: Robin Murphy <robin.murphy@....com>, Laura Abbott <labbott@...hat.com>, linux-kernel@...r.kernel.org, Christoph Hellwig <hch@....de>, Marek Szyprowski <m.szyprowski@...sung.com>, Jesper Dangaard Brouer <brouer@...hat.com>, Allison Randal <allison@...utok.net>, Greg Kroah-Hartman <gregkh@...uxfoundation.org>, Thomas Gleixner <tglx@...utronix.de>, Stephen Boyd <swboyd@...omium.org>, Dan Carpenter <dan.carpenter@...cle.com>, Semmle Security Reports <security-reports@...mle.com>, iommu@...ts.linux-foundation.org Subject: Re: [PATCH v2] dma-mapping: Move vmap address checks into dma_map_single() Please split the usb and dma-mapping parts into separate patches. > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h > index 4a1c4fca475a..12dbd07f74f2 100644 > --- a/include/linux/dma-mapping.h > +++ b/include/linux/dma-mapping.h > @@ -583,6 +583,13 @@ static inline unsigned long dma_get_merge_boundary(struct device *dev) > static inline dma_addr_t dma_map_single_attrs(struct device *dev, void *ptr, > size_t size, enum dma_data_direction dir, unsigned long attrs) > { > + /* DMA must never operate on areas that might be remapped. */ > + if (WARN_ONCE(is_vmalloc_addr(ptr), > + "%s %s: driver maps %lu bytes from vmalloc area\n", > + dev ? dev_driver_string(dev) : "unknown driver", > + dev ? dev_name(dev) : "unknown device", size)) > + return DMA_MAPPING_ERROR; a NULL device isn't supported any more, so we can remove the handling for it here.
Powered by blists - more mailing lists