linux-kernel - Re: [PATCH] drm: lima: Add support for multiple reset lines

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAKGbVbspHBNtEPGc_RbHdKUyrBTmQADueUSO+U+cFLUPzw0fBQ@mail.gmail.com>
Date:   Sat, 5 Oct 2019 17:27:01 +0800
From:   Qiang Yu <yuq825@...il.com>
To:     John Stultz <john.stultz@...aro.org>
Cc:     lkml <linux-kernel@...r.kernel.org>,
        Peter Griffin <peter.griffin@...aro.org>,
        David Airlie <airlied@...ux.ie>,
        Daniel Vetter <daniel@...ll.ch>,
        dri-devel <dri-devel@...ts.freedesktop.org>,
        lima@...ts.freedesktop.org
Subject: Re: [PATCH] drm: lima: Add support for multiple reset lines

On Wed, Oct 2, 2019 at 2:29 AM John Stultz <john.stultz@...aro.org> wrote:
>
> From: Peter Griffin <peter.griffin@...aro.org>
>
> Some SoCs like HiKey have 2 reset lines, so update
> to use the devm_reset_control_array_* variant of the
> API so that multiple resets can be specified in DT.
>
> Cc: Qiang Yu <yuq825@...il.com>
> Cc: David Airlie <airlied@...ux.ie>
> Cc: Daniel Vetter <daniel@...ll.ch>
> Cc: dri-devel@...ts.freedesktop.org
> Cc: lima@...ts.freedesktop.org
> Signed-off-by: Peter Griffin <peter.griffin@...aro.org>
> Signed-off-by: John Stultz <john.stultz@...aro.org>
> ---
>  drivers/gpu/drm/lima/lima_device.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/lima/lima_device.c b/drivers/gpu/drm/lima/lima_device.c
> index d86b8d81a483..e3e0ca11382e 100644
> --- a/drivers/gpu/drm/lima/lima_device.c
> +++ b/drivers/gpu/drm/lima/lima_device.c
> @@ -105,7 +105,8 @@ static int lima_clk_init(struct lima_device *dev)
>         if (err)
>                 goto error_out0;
>
> -       dev->reset = devm_reset_control_get_optional(dev->dev, NULL);
> +       dev->reset = devm_reset_control_array_get_optional_shared(dev->dev);
> +
>         if (IS_ERR(dev->reset)) {
>                 err = PTR_ERR(dev->reset);
>                 if (err != -EPROBE_DEFER)
> --
> 2.17.1
>

Looks good for me, patch is:
Reviewed-by: Qiang Yu <yuq825@...il.com>

I'll apply it to drm-misc-next.

Thanks,
Qiang