linux-kernel - Re: [PATCH v4 1/2] dt-bindings: soc: al-pos: Amazon's Annapurna Labs POS

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ee5a0727-6cc0-062b-0797-20fecdf1a450@amazon.com>
Date:   Sun, 6 Oct 2019 12:10:50 +0300
From:   "Shenhar, Talel" <talel@...zon.com>
To:     Rob Herring <robh+dt@...nel.org>
CC:     Marc Zyngier <maz@...nel.org>, Mark Rutland <mark.rutland@....com>,
        "Arnd Bergmann" <arnd@...db.de>, Borislav Petkov <bp@...en8.de>,
        "Mauro Carvalho Chehab" <mchehab@...nel.org>,
        James Morse <james.morse@....com>,
        David Miller <davem@...emloft.net>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Paul E. McKenney" <paulmck@...ux.ibm.com>,
        <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        linux-edac <linux-edac@...r.kernel.org>,
        "Woodhouse, David" <dwmw@...zon.co.uk>,
        Benjamin Herrenschmidt <benh@...nel.crashing.org>,
        "Hawa, Hanna" <hhhawa@...zon.com>,
        "Krupnik, Ronen" <ronenk@...zon.com>,
        Jonathan Chocron <jonnyc@...zon.com>,
        "Hanoch, Uri" <hanochu@...zon.com>, <amirkl@...zon.com>,
        "Wasserstrom, Barak" <barakw@...zon.com>
Subject: Re: [PATCH v4 1/2] dt-bindings: soc: al-pos: Amazon's Annapurna Labs
 POS

thanks for the review.

On 10/4/2019 6:05 PM, Rob Herring wrote:
> On Thu, Oct 3, 2019 at 6:33 AM Talel Shenhar <talel@...zon.com> wrote:
>
> Fails 'make dt_binding_check' (drop the '-'):
ack, shall be part of v5
>
>> +
>> +examples:
>> +  - |
>> +    al_pos_edac@...70084 {
> edac@...
ack, shall be part of v5
>
>> +      compatible = "amazon,al-pos-edac";
>> +      reg = <0x0 0xf0070084 0x0 0x00000008>;
>> +      interrupt-parent = <&amazon_system_fabric>;
>> +      interrupts = <24 IRQ_TYPE_LEVEL_HIGH>;
> Not documented.

looks good?

    interrupts:

     description: Interrupt for the error event.
     maxItems: 1