linux-kernel - Re: [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead of clock numbers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191006110212.4e6fe30e@archlinux>
Date:   Sun, 6 Oct 2019 11:02:12 +0100
From:   Jonathan Cameron <jic23@...nel.org>
To:     Krzysztof Kozlowski <krzk@...nel.org>
Cc:     Rob Herring <robh+dt@...nel.org>,
        Mark Rutland <mark.rutland@....com>,
        Kukjin Kim <kgene@...nel.org>,
        Hartmut Knaack <knaack.h@....de>,
        Lars-Peter Clausen <lars@...afoo.de>,
        Peter Meerwald-Stadler <pmeerw@...erw.net>,
        Sebastian Reichel <sre@...nel.org>,
        Alessandro Zummo <a.zummo@...ertech.it>,
        Alexandre Belloni <alexandre.belloni@...tlin.com>,
        devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-iio@...r.kernel.org, linux-pm@...r.kernel.org,
        linux-rtc@...r.kernel.org
Subject: Re: [PATCH 4/4] dt-bindings: iio: adc: exynos: Use defines instead
 of clock numbers

On Wed,  2 Oct 2019 18:07:44 +0200
Krzysztof Kozlowski <krzk@...nel.org> wrote:

> Make the examples in Exynos ADC bindings more readable and bring them
> closer to real DTS by using defines for clocks.
> 
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Acked-by: Jonathan Cameron <Jonathan.Cameron@...wei.com>

> ---
>  .../devicetree/bindings/iio/adc/samsung,exynos-adc.yaml     | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> index a0a9b909ac40..a3010e7ea051 100644
> --- a/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> +++ b/Documentation/devicetree/bindings/iio/adc/samsung,exynos-adc.yaml
> @@ -135,6 +135,8 @@ examples:
>      };
>  
>    - |
> +    #include <dt-bindings/clock/exynos3250.h>
> +
>      adc@...c0000 {
>          compatible = "samsung,exynos3250-adc";
>          reg = <0x126C0000 0x100>;
> @@ -142,8 +144,8 @@ examples:
>          #io-channel-cells = <1>;
>          io-channel-ranges;
>  
> -        clocks = <&cmu 0>, // CLK_TSADC
> -                 <&cmu 1>; // CLK_SCLK_TSADC
> +        clocks = <&cmu CLK_TSADC>,
> +                 <&cmu CLK_SCLK_TSADC>;
>          clock-names = "adc", "sclk";
>  
>          vdd-supply = <&buck5_reg>;