linux-kernel - Re: staging: vt6655: Fix memory leak in vt6655

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ea5e4945-b48f-0955-ba52-071ef1bb0e57@web.de>
Date:   Sun, 6 Oct 2019 07:39:30 +0200
From:   Markus Elfring <Markus.Elfring@....de>
To:     Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Navid Emamdoost <navid.emamdoost@...il.com>,
        devel@...verdev.osuosl.org, kernel-janitors@...r.kernel.org
Cc:     linux-kernel@...r.kernel.org, Navid Emamdoost <emamd001@....edu>,
        Kangjie Lu <kjlu@....edu>, Stephen McCamant <smccaman@....edu>,
        Forest Bond <forest@...ttletooquiet.net>,
        Luis Chamberlain <mcgrof@...nel.org>,
        Madhumitha Prabakaran <madhumithabiw@...il.com>,
        Malcolm Priestley <tvboxspy@...il.com>
Subject: Re: staging: vt6655: Fix memory leak in vt6655_probe

>>> In vt6655_probe, if vnt_init() fails the cleanup code needs to be called
>>> like other error handling cases. The call to device_free_info() is
>>> added.
>>
>> Please improve this change description.
>
> It is fine as-is, please do not confuse people.

Would you like to clarify a known guideline once more?
https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?id=43b815c6a8e7dbccb5b8bd9c4b099c24bc22d135#n151
“…
Describe your changes in imperative mood,
…”

Regards,
Markus