lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 06 Oct 2019 11:22:31 +0300 From: Kalle Valo <kvalo@...eaurora.org> To: Johan Hovold <johan@...nel.org> Cc: Denis Efremov <efremov@...ux.com>, linux-wireless@...r.kernel.org, netdev@...r.kernel.org, linux-kernel@...r.kernel.org, Amitkumar Karwar <amitkarwar@...il.com>, Siva Rebbagondla <siva8118@...il.com> Subject: Re: [PATCH] rsi: fix potential null dereference in rsi_probe() Johan Hovold <johan@...nel.org> writes: > On Fri, Oct 04, 2019 at 01:47:36PM +0000, Kalle Valo wrote: >> Denis Efremov <efremov@...ux.com> wrote: >> >> > The id pointer can be NULL in rsi_probe(). > > While the existing code in rsi_probe() may lead you to believe that, > this statement is false. > >> > It is checked everywhere except >> > for the else branch in the idProduct condition. The patch adds NULL check >> > before the id dereference in the rsi_dbg() call. >> > >> > Fixes: 54fdb318c111 ("rsi: add new device model for 9116") >> > Cc: Amitkumar Karwar <amitkarwar@...il.com> >> > Cc: Siva Rebbagondla <siva8118@...il.com> >> > Cc: Kalle Valo <kvalo@...eaurora.org> >> > Signed-off-by: Denis Efremov <efremov@...ux.com> >> >> Patch applied to wireless-drivers-next.git, thanks. >> >> f170d44bc4ec rsi: fix potential null dereference in rsi_probe() > > I just sent a revert to prevent the confusion from spreading (e.g. to > stable autosel and contributers looking for things to work on). Hope you > don't mind, Kalle. That's great, thanks Johan. -- Kalle Valo
Powered by blists - more mailing lists