linux-kernel - Re: [PATCH -next 16/34] rtc: meson: use devm_platform_ioremap

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <7hk19gfmwk.fsf@baylibre.com>
Date:   Mon, 07 Oct 2019 11:09:15 -0700
From:   Kevin Hilman <khilman@...libre.com>
To:     YueHaibing <yuehaibing@...wei.com>, a.zummo@...ertech.it,
        alexandre.belloni@...tlin.com, joel@....id.au, andrew@...id.au,
        nicolas.ferre@...rochip.com, ludovic.desroches@...rochip.com,
        computersforpeace@...il.com, gregory.0xf0@...il.com,
        f.fainelli@...il.com, bcm-kernel-feedback-list@...adcom.com,
        linus.walleij@...aro.org, baruch@...s.co.il, paul@...pouillou.net,
        vz@...ia.com, slemieux.tyco@...il.com, eddie.huang@...iatek.com,
        sean.wang@...iatek.com, matthias.bgg@...il.com,
        patrice.chotard@...com, mcoquelin.stm32@...il.com,
        alexandre.torgue@...com, mripard@...nel.org, wens@...e.org,
        thierry.reding@...il.com, jonathanh@...dia.com,
        linux@...sktech.co.nz, michal.simek@...inx.com
Cc:     linux-rtc@...r.kernel.org, linux-kernel@...r.kernel.org,
        linux-arm-kernel@...ts.infradead.org,
        linux-aspeed@...ts.ozlabs.org, linux-amlogic@...ts.infradead.org,
        linux-mediatek@...ts.infradead.org,
        linux-stm32@...md-mailman.stormreply.com,
        linux-tegra@...r.kernel.org, YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH -next 16/34] rtc: meson: use devm_platform_ioremap_resource() to simplify code

YueHaibing <yuehaibing@...wei.com> writes:

> Use devm_platform_ioremap_resource() to simplify the code a bit.
> This is detected by coccinelle.
>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Kevin Hilman <khilman@...libre.com>

> ---
>  drivers/rtc/rtc-meson.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/rtc/rtc-meson.c b/drivers/rtc/rtc-meson.c
> index e08b981..9bd8478 100644
> --- a/drivers/rtc/rtc-meson.c
> +++ b/drivers/rtc/rtc-meson.c
> @@ -292,7 +292,6 @@ static int meson_rtc_probe(struct platform_device *pdev)
>  	};
>  	struct device *dev = &pdev->dev;
>  	struct meson_rtc *rtc;
> -	struct resource *res;
>  	void __iomem *base;
>  	int ret;
>  	u32 tm;
> @@ -312,8 +311,7 @@ static int meson_rtc_probe(struct platform_device *pdev)
>  	rtc->rtc->ops = &meson_rtc_ops;
>  	rtc->rtc->range_max = U32_MAX;
>  
> -	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> -	base = devm_ioremap_resource(dev, res);
> +	base = devm_platform_ioremap_resource(pdev, 0);
>  	if (IS_ERR(base))
>  		return PTR_ERR(base);
>  
> -- 
> 2.7.4