linux-kernel - Re: Potential NULL pointer deference in net: sched

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <b2997ffb-728a-b4ee-abfa-2c9fe9869d8b@gmail.com>
Date:   Mon, 7 Oct 2019 14:20:21 -0700
From:   Eric Dumazet <eric.dumazet@...il.com>
To:     Yizhuo Zhai <yzhai003@....edu>,
        Jamal Hadi Salim <jhs@...atatu.com>,
        Cong Wang <xiyou.wangcong@...il.com>,
        Jiri Pirko <jiri@...nulli.us>, netdev@...r.kernel.org,
        linux-kernel@...r.kernel.org, Zhiyun Qian <zhiyunq@...ucr.edu>,
        Chengyu Song <csong@...ucr.edu>
Subject: Re: Potential NULL pointer deference in net: sched



On 10/7/19 2:08 PM, Yizhuo Zhai wrote:
> Hi All:
> 
> net/sched/sch_mq.c:
> Inside function mq_dump_class(), mq_queue_get() could return NULL,
> however, the return value of dev_queue is not checked  and get used.
> This could potentially be unsafe.
> 
> 

Not really.

mq_dump_class() is called by a layer that made sure the @cl argument
was not complete garbage.