linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: light: Add binding for ADUX1020

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a60fb9ea8922c1eb532e0b7ef0a69abcc9306255.camel@analog.com>
Date:   Mon, 7 Oct 2019 10:21:16 +0000
From:   "Ardelean, Alexandru" <alexandru.Ardelean@...log.com>
To:     "robh+dt@...nel.org" <robh+dt@...nel.org>,
        "Hennerich, Michael" <Michael.Hennerich@...log.com>,
        "manivannan.sadhasivam@...aro.org" <manivannan.sadhasivam@...aro.org>,
        "lars@...afoo.de" <lars@...afoo.de>,
        "jic23@...nel.org" <jic23@...nel.org>,
        "pmeerw@...erw.net" <pmeerw@...erw.net>,
        "knaack.h@....de" <knaack.h@....de>
CC:     "devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>
Subject: Re: [PATCH 1/2] dt-bindings: iio: light: Add binding for ADUX1020

On Mon, 2019-10-07 at 15:40 +0530, Manivannan Sadhasivam wrote:
> [External]
> 
> Add devicetree binding for Analog Devices ADUX1020 Photometric
> sensor.
> 

Hey,

Thanks for the patches.

This dt-binding docs is in text format.
dt-binding docs now need to be in YAML format.

Also, patches for dt-bindings docs usually come after the driver is added.
So, this patch should be the second in the series, not the first.

Alex

> Signed-off-by: Manivannan Sadhasivam <manivannan.sadhasivam@...aro.org>
> ---
>  .../bindings/iio/light/adux1020.txt           | 22 +++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644
> Documentation/devicetree/bindings/iio/light/adux1020.txt
> 
> diff --git a/Documentation/devicetree/bindings/iio/light/adux1020.txt
> b/Documentation/devicetree/bindings/iio/light/adux1020.txt
> new file mode 100644
> index 000000000000..e896dda30e36
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/light/adux1020.txt
> @@ -0,0 +1,22 @@
> +Analog Devices ADUX1020 Photometric sensor
> +
> +Link to datasheet: 
> https://www.analog.com/media/en/technical-documentation/data-sheets/ADUX1020.pdf
> +
> +Required properties:
> +
> + - compatible: should be "adi,adux1020"
> + - reg: the I2C address of the sensor
> +
> +Optional properties:
> +
> + - interrupts: interrupt mapping for IRQ as documented in
> +   Documentation/devicetree/bindings/interrupt-controller/interrupts.txt
> +
> +Example:
> +
> +adux1020@64 {
> +	compatible = "adi,adux1020";
> +	reg = <0x64>;
> +	interrupt-parent = <&msmgpio>;
> +	interrupts = <24 IRQ_TYPE_LEVEL_HIGH>;
> +};