linux-kernel - RE: [GIT PULL] usercopy structs for v5.4-rc2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d0944174abe24165ac5cb63c52b89c42@AcuMS.aculab.com>
Date:   Mon, 7 Oct 2019 13:11:46 +0000
From:   David Laight <David.Laight@...LAB.COM>
To:     'Nathan Chancellor' <natechancellor@...il.com>,
        Linus Torvalds <torvalds@...ux-foundation.org>
CC:     Christian Brauner <christian.brauner@...ntu.com>,
        "Linux Kernel Mailing List" <linux-kernel@...r.kernel.org>
Subject: RE: [GIT PULL] usercopy structs for v5.4-rc2

From: Nathan Chancellor
> Sent: 04 October 2019 20:44
...
> > IOW, the code should have just been
> >
> >         ret = test(umem_src == NULL, "kmalloc failed");
> >         if (ret) ...
> 
> Yes, I had this as the original fix but I tried to keep the same
> intention as the original author. I should have gone with my gut. Sorry
> for the ugliness, I'll try to be better in the future.

This rather begs the question about why 'usercopy' is ever calling kmalloc() at all.
Never mind some perverted style for reporting errors.

	David

-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)