linux-kernel - Re: [PATCH -next] drm/amd/display: remove set but not used variable 'core

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <db644945-24df-7d67-7fc6-880833466593@amd.com>
Date:   Mon, 7 Oct 2019 14:06:46 +0000
From:   Harry Wentland <hwentlan@....com>
To:     YueHaibing <yuehaibing@...wei.com>,
        "Wentland, Harry" <Harry.Wentland@....com>,
        "Li, Sun peng (Leo)" <Sunpeng.Li@....com>,
        "Deucher, Alexander" <Alexander.Deucher@....com>,
        "Koenig, Christian" <Christian.Koenig@....com>,
        "Zhou, David(ChunMing)" <David1.Zhou@....com>,
        "airlied@...ux.ie" <airlied@...ux.ie>,
        "daniel@...ll.ch" <daniel@...ll.ch>,
        "Lakha, Bhawanpreet" <Bhawanpreet.Lakha@....com>,
        "Koo, Anthony" <Anthony.Koo@....com>,
        "Cyr, Aric" <Aric.Cyr@....com>,
        "Harmanprit.Tatla@....com" <Harmanprit.Tatla@....com>,
        "bayan.zabihiyan@....com" <bayan.zabihiyan@....com>,
        "Othman, Ahmad" <Ahmad.Othman@....com>,
        "Amini, Reza" <Reza.Amini@....com>
CC:     "amd-gfx@...ts.freedesktop.org" <amd-gfx@...ts.freedesktop.org>,
        "dri-devel@...ts.freedesktop.org" <dri-devel@...ts.freedesktop.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH -next] drm/amd/display: remove set but not used variable
 'core_freesync'

On 2019-10-06 6:57 a.m., YueHaibing wrote:
> Fixes gcc '-Wunused-but-set-variable' warning:
> 
> rivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:
>  In function mod_freesync_get_settings:
> drivers/gpu/drm/amd/amdgpu/../display/modules/freesync/freesync.c:984:24:
>  warning: variable core_freesync set but not used [-Wunused-but-set-variable]
> 
> It is not used since commit 98e6436d3af5 ("drm/amd/display: Refactor FreeSync module")
> 
> Reported-by: Hulk Robot <hulkci@...wei.com>
> Signed-off-by: YueHaibing <yuehaibing@...wei.com>

Reviewed-by: Harry Wentland <harry.wentland@....com>

Harry

> ---
>  drivers/gpu/drm/amd/display/modules/freesync/freesync.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> index 9ce56a8..237dda7 100644
> --- a/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> +++ b/drivers/gpu/drm/amd/display/modules/freesync/freesync.c
> @@ -981,13 +981,9 @@ void mod_freesync_get_settings(struct mod_freesync *mod_freesync,
>  		unsigned int *inserted_frames,
>  		unsigned int *inserted_duration_in_us)
>  {
> -	struct core_freesync *core_freesync = NULL;
> -
>  	if (mod_freesync == NULL)
>  		return;
>  
> -	core_freesync = MOD_FREESYNC_TO_CORE(mod_freesync);
> -
>  	if (vrr->supported) {
>  		*v_total_min = vrr->adjust.v_total_min;
>  		*v_total_max = vrr->adjust.v_total_max;
>