linux-kernel - Re: [PATCH 3/3] usb: dwc3: Remove dev_err() on platform_get

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5d9b5a5f.1c69fb81.842f8.329e@mx.google.com>
Date:   Mon, 07 Oct 2019 08:31:42 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     "Rafael J . Wysocki" <rafael@...nel.org>,
        Felipe Balbi <balbi@...nel.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Hans de Goede <hdegoede@...hat.com>
Cc:     Hans de Goede <hdegoede@...hat.com>, linux-usb@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] usb: dwc3: Remove dev_err() on platform_get_irq() failure

Quoting Hans de Goede (2019-10-05 14:04:49)
> Since commit 7723f4c5ecdb ("driver core: platform: Add an error message to
> platform_get_irq*()"), platform_get_irq() will call dev_err() itself on
> failure, so there is no need for the driver to also do this.
> 
> Signed-off-by: Hans de Goede <hdegoede@...hat.com>
> ---

Reviewed-by: Stephen Boyd <swboyd@...omium.org>