linux-kernel - Re: [PATCH] firmware: vpd: Add an interface to read VPD value

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5d9b5b3e.1c69fb81.7203c.1215@mx.google.com>
Date:   Mon, 07 Oct 2019 08:35:25 -0700
From:   Stephen Boyd <swboyd@...omium.org>
To:     Cheng-yi Chiang <cychiang@...omium.org>,
        Guenter Roeck <linux@...ck-us.net>
Cc:     Tzung-Bi Shih <tzungbi@...gle.com>,
        Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
        ALSA development <alsa-devel@...a-project.org>,
        Hung-Te Lin <hungte@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Sean Paul <seanpaul@...omium.org>,
        Mark Brown <broonie@...nel.org>,
        Dylan Reid <dgreid@...omium.org>,
        Tzung-Bi Shih <tzungbi@...omium.org>,
        Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
Subject: Re: [PATCH] firmware: vpd: Add an interface to read VPD value

Quoting Cheng-yi Chiang (2019-10-07 06:58:41)
> 
> Hi Guenter,
> Thanks for the quick review.
> I'll update accordingly in v2.

I'd prefer this use the nvmem framework which already handles many of
the requirements discussed here. Implement an nvmem provider and figure
out how to wire that up to the kernel users. Also, please include a user
of the added support, otherwise it is impossible to understand how this
code is used.