linux-kernel - Re: [Lkcamp] [RFC PATCH] media: vimc: vimc_pix_map_fmt_info() can be static

Open Source and information security mailing list archives

Message-ID: <fe7f95e9-8eb9-5ca2-50de-fdda966946ff@collabora.com>
Date:   Mon, 7 Oct 2019 13:12:32 -0300
From:   Helen Koike <helen.koike@...labora.com>
To:     André Almeida <andrealmeida@...eup.net>,
        kbuild test robot <lkp@...el.com>,
        "Carlos E. C. Barbosa" <climacobarbosacee@...il.com>
Cc:     linux-kernel@...r.kernel.org, lkcamp@...ts.libreplanetbr.org,
        kbuild-all@...org, Shuah Khan <skhan@...uxfoundation.org>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        linux-media@...r.kernel.org
Subject: Re: [Lkcamp] [RFC PATCH] media: vimc: vimc_pix_map_fmt_info() can be
 static

On 10/7/19 12:18 PM, André Almeida wrote:
> Hi Helen,
> 
> On 10/5/19 10:36 PM, Helen Koike wrote:
>> Hi Carlos,
>>
>> On 10/5/19 9:28 PM, kbuild test robot wrote:
>>> Fixes: 4d124d159dff ("media: vimc: get pixformat info from v4l2_format_info to avoid code repetition")
>> Usually, the Fixes flag is used for something that is already accepted in mainline.
>> If you want to fix anything in the previous version of the patch you sent, you should update the last patch
>> and re-send it as a new version, i.e. [PATCH v2], adding a change log just after the 3 dashes to explain
>> what you changed.
> 
> The author of this commit is the "kbuild test robot" rather than Carlos,
> it was generated automatically to fix a warning the robot found at
> Carlos commit :)

Ah, thanks André for the heads up, I didn't notice it, sorry about that Carlos.

Helen

> 
>> Check this example:
>>
>> https://www.spinics.net/lists/linux-media/msg158251.html
>>
>> Let me know if you need help!
>> And thanks for working on this :)
>> Helen
>>
>>> Signed-off-by: kbuild test robot <lkp@...el.com>
>>> ---
>>>  vimc-common.c |    2 +-
>>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/drivers/media/platform/vimc/vimc-common.c b/drivers/media/platform/vimc/vimc-common.c
>>> index 9ea698810e1a1..c37442aba70b1 100644
>>> --- a/drivers/media/platform/vimc/vimc-common.c
>>> +++ b/drivers/media/platform/vimc/vimc-common.c
>>> @@ -118,7 +118,7 @@ static struct vimc_pix_map_fmt vimc_pix_map_fmt_list[] = {
>>>  	},
>>>  };
>>>  
>>> -struct vimc_pix_map vimc_pix_map_fmt_info(struct vimc_pix_map_fmt *vfmt)
>>> +static struct vimc_pix_map vimc_pix_map_fmt_info(struct vimc_pix_map_fmt *vfmt)
>>>  {
>>>  
>>>  	struct vimc_pix_map vpix = {
>>>
>> _______________________________________________
>> Lkcamp mailing list
>> Lkcamp@...ts.libreplanetbr.org
>> https://lists.libreplanetbr.org/mailman/listinfo/lkcamp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives