linux-kernel - Re: [PATCH] drm: panels: fix spi aliases of former omap panels

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191007170446.yotb24s6jhe6nx3r@earth.universe>
Date:   Mon, 7 Oct 2019 19:04:46 +0200
From:   Sebastian Reichel <sre@...nel.org>
To:     Andreas Kemnade <andreas@...nade.info>
Cc:     thierry.reding@...il.com, sam@...nborg.org, airlied@...ux.ie,
        daniel@...ll.ch, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org,
        omi Valkeinen <tomi.valkeinen@...com>,
        Laurent Pinchart <laurent.pinchart@...asonboard.com>,
        Discussions about the Letux Kernel 
        <letux-kernel@...nphoenux.org>, Tony Lindgren <tony@...mide.com>,
        Jyri Sarha <jsarha@...com>,
        Linux-OMAP <linux-omap@...r.kernel.org>,
        linux-arm-kernel <linux-arm-kernel@...ts.infradead.org>
Subject: Re: [PATCH] drm: panels: fix spi aliases of former omap panels

Hi,

On Mon, Oct 07, 2019 at 06:41:30PM +0200, Andreas Kemnade wrote:
> When the panels were moved from omap/displays/ to panel/
> omapdss prefix was stripped, which cause spi modalias
> to not contain the vendor-prefix anymore.
> 
> so we had e.g. in former times:
> compatible=omapdss,tpo,td028ttec1 -> modalias=spi:tpo,td028ttec1
> now:
> compatible=tpo,td028ttec1 -> modalias=spi:td028ttec1
> 
> This is consistent with other drivers. Tested the td028ttec.c
> only, but the pattern looks the same for the other ones.
> 
> Fixes: 45f16c82db7e8 ("drm/omap: displays: Remove unused panel drivers")
> Signed-off-by: Andreas Kemnade <andreas@...nade.info>
> ---

Patch looks good to me, but you have one false positive.

> [...]
>
> diff --git a/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c b/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> index 46cd9a2501298..838d39a263f53 100644
> --- a/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> +++ b/drivers/gpu/drm/panel/panel-sharp-ls037v7dw01.c
> @@ -204,7 +204,7 @@ static int ls037v7dw01_remove(struct platform_device *pdev)
>  }
>  
>  static const struct of_device_id ls037v7dw01_of_match[] = {
> -	{ .compatible = "sharp,ls037v7dw01", },
> +	{ .compatible = "ls037v7dw01", },
>  	{ /* sentinel */ },
>  };
>  

The DT compatible should have a vendor prefix.

> [...]

-- Sebastian

Download attachment "signature.asc" of type "application/pgp-signature" (834 bytes)