linux-kernel - Re: [PATCH] proc:fix confusing macro arg name

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56474105-0df0-975b-a347-711c1c6422f2@linux.intel.com>
Date:   Tue, 8 Oct 2019 15:04:51 +0800
From:   "Li, Aubrey" <aubrey.li@...ux.intel.com>
To:     linmiaohe <linmiaohe@...wei.com>,
        "adobriyan@...il.com" <adobriyan@...il.com>,
        "tglx@...utronix.de" <tglx@...utronix.de>,
        "akpm@...ux-foundation.org" <akpm@...ux-foundation.org>,
        "dhowells@...hat.com" <dhowells@...hat.com>,
        "cyphar@...har.com" <cyphar@...har.com>,
        "christian@...uner.io" <christian@...uner.io>
Cc:     Mingfangsen <mingfangsen@...wei.com>,
        "mm-commits@...r.kernel.org" <mm-commits@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>
Subject: Re: [PATCH] proc:fix confusing macro arg name

On 2019/10/8 14:44, linmiaohe wrote:
> Add suitable additional cc's as Andrew Morton suggested.
> Get cc list from get_maintainer script:
> [root@...alhost mm]# ./scripts/get_maintainer.pl 0001-proc-fix-confusing-macro-arg-name.patch 
> Alexey Dobriyan <adobriyan@...il.com> (reviewer:PROC FILESYSTEM)
> linux-kernel@...r.kernel.org (open list:PROC FILESYSTEM)
> linux-fsdevel@...r.kernel.org (open list:PROC FILESYSTEM)
> 
> ------------------------------------------------------
> From: Miaohe Lin <linmiaohe@...wei.com>
> Subject: fix confusing macro arg name
> 
> state_size and ops are in the wrong position, fix it.
> 
> Signed-off-by: Miaohe Lin <linmiaohe@...wei.com>
> Reviewed-by: Andrew Morton <akpm@...ux-foundation.org>
> Cc: Alexey Dobriyan <adobriyan@...il.com>
> Signed-off-by: Andrew Morton <akpm@...ux-foundation.org>
> ---

Good catch!

This is interesting, I saw this interface has 50+ callers,
How did they work before? ;)

Thanks,
-Aubrey

> 
>  include/linux/proc_fs.h | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/linux/proc_fs.h b/include/linux/proc_fs.h index a705aa2d03f9..0640be56dcbd 100644
> --- a/include/linux/proc_fs.h
> +++ b/include/linux/proc_fs.h
> @@ -58,8 +58,8 @@ extern int remove_proc_subtree(const char *, struct proc_dir_entry *);  struct proc_dir_entry *proc_create_net_data(const char *name, umode_t mode,
>  		struct proc_dir_entry *parent, const struct seq_operations *ops,
>  		unsigned int state_size, void *data);
> -#define proc_create_net(name, mode, parent, state_size, ops) \
> -	proc_create_net_data(name, mode, parent, state_size, ops, NULL)
> +#define proc_create_net(name, mode, parent, ops, state_size) \
> +	proc_create_net_data(name, mode, parent, ops, state_size, NULL)
>  struct proc_dir_entry *proc_create_net_single(const char *name, umode_t mode,
>  		struct proc_dir_entry *parent,
>  		int (*show)(struct seq_file *, void *), void *data);
> --
> 2.21.GIT
> 
>