[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <AM5PR04MB329984A4B6BAD35510310CF5F59A0@AM5PR04MB3299.eurprd04.prod.outlook.com>
Date: Tue, 8 Oct 2019 07:11:47 +0000
From: Xiaowei Bao <xiaowei.bao@....com>
To: Shawn Guo <shawnguo@...nel.org>
CC: "robh+dt@...nel.org" <robh+dt@...nel.org>,
"mark.rutland@....com" <mark.rutland@....com>,
Leo Li <leoyang.li@....com>,
"M.h. Lian" <minghuan.lian@....com>,
Mingkai Hu <mingkai.hu@....com>, Roy Zang <roy.zang@....com>,
"lorenzo.pieralisi@....com" <lorenzo.pieralisi@....com>,
"linux-pci@...r.kernel.org" <linux-pci@...r.kernel.org>,
"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
"linuxppc-dev@...ts.ozlabs.org" <linuxppc-dev@...ts.ozlabs.org>,
"bhelgaas@...gle.com" <bhelgaas@...gle.com>,
"Z.q. Hou" <zhiqiang.hou@....com>
Subject: RE: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support
> -----Original Message-----
> From: Shawn Guo <shawnguo@...nel.org>
> Sent: 2019年10月3日 17:11
> To: Xiaowei Bao <xiaowei.bao@....com>
> Cc: robh+dt@...nel.org; mark.rutland@....com; Leo Li
> <leoyang.li@....com>; M.h. Lian <minghuan.lian@....com>; Mingkai Hu
> <mingkai.hu@....com>; Roy Zang <roy.zang@....com>;
> lorenzo.pieralisi@....com; linux-pci@...r.kernel.org;
> devicetree@...r.kernel.org; linux-kernel@...r.kernel.org;
> linux-arm-kernel@...ts.infradead.org; linuxppc-dev@...ts.ozlabs.org;
> bhelgaas@...gle.com; Z.q. Hou <zhiqiang.hou@....com>
> Subject: Re: [PATCH v6 3/3] PCI: layerscape: Add LS1028a support
>
> On Mon, Sep 02, 2019 at 11:43:19AM +0800, Xiaowei Bao wrote:
> > Add support for the LS1028a PCIe controller.
> >
> > Signed-off-by: Xiaowei Bao <xiaowei.bao@....com>
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@....com>
> > ---
> > v2:
> > - No change.
> > v3:
> > - Reuse the ls2088 driver data structurt.
> > v4:
> > - No change.
> > v5:
> > - No change.
> > v6:
> > - No change.
> >
> > drivers/pci/controller/dwc/pci-layerscape.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/pci/controller/dwc/pci-layerscape.c
> > b/drivers/pci/controller/dwc/pci-layerscape.c
> > index 3a5fa26..f24f79a 100644
> > --- a/drivers/pci/controller/dwc/pci-layerscape.c
> > +++ b/drivers/pci/controller/dwc/pci-layerscape.c
> > @@ -263,6 +263,7 @@ static const struct ls_pcie_drvdata ls2088_drvdata
> > = { static const struct of_device_id ls_pcie_of_match[] = {
> > { .compatible = "fsl,ls1012a-pcie", .data = &ls1046_drvdata },
> > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> > + { .compatible = "fsl,ls1028a-pcie", .data = &ls2088_drvdata },
>
> I think you can save this driver change by using "fsl,ls2088a-pcie" as
> compatible fallback like below.
>
> compatible = "fsl,ls1028a-pcie", "fsl,ls2088a-pcie";
Yes, it is ok to do so, but according to the previous code, I think add a new compatible " fsl,ls1028a-pcie " to driver is better.
Thanks
Xiaowei
>
> Shawn
>
> > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> > { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> > --
> > 2.9.5
> >
Powered by blists - more mailing lists