linux-kernel - Re: [PATCH] btrfs: block-group: Rework documentation of check_system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c120d3a8-2e58-d109-191c-bd75ee8111b7@suse.com>
Date:   Tue, 8 Oct 2019 10:28:06 +0300
From:   Nikolay Borisov <nborisov@...e.com>
To:     Marcos Paulo de Souza <marcos.souza.org@...il.com>, clm@...com,
        David Sterba <dsterba@...e.com>
Cc:     Josef Bacik <josef@...icpanda.com>,
        "open list:BTRFS FILE SYSTEM" <linux-btrfs@...r.kernel.org>,
        open list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] btrfs: block-group: Rework documentation of
 check_system_chunk function



On 8.10.19 г. 3:50 ч., Marcos Paulo de Souza wrote:
> Commit 4617ea3a52cf (" Btrfs: fix necessary chunk tree space calculation
> when allocating a chunk") removed the is_allocation argument from
> check_system_chunk, since the formula for reserving the necessary space
> for allocation or removing a chunk would be the same.
> 
> So, rework the comment by removing the mention of is_allocation
> argument.
> 
> Signed-off-by: Marcos Paulo de Souza <marcos.souza.org@...il.com>

Reviewed-by: Nikolay Borisov <nborisov@...e.com>


> ---
>  fs/btrfs/block-group.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/fs/btrfs/block-group.c b/fs/btrfs/block-group.c
> index bf7e3f23bba7..4910921838db 100644
> --- a/fs/btrfs/block-group.c
> +++ b/fs/btrfs/block-group.c
> @@ -2987,9 +2987,7 @@ static u64 get_profile_num_devs(struct btrfs_fs_info *fs_info, u64 type)
>  }
> 
>  /*
> - * If @is_allocation is true, reserve space in the system space info necessary
> - * for allocating a chunk, otherwise if it's false, reserve space necessary for
> - * removing a chunk.
> + * Reserve space in the system space for allocating or removing a chunk
>   */
>  void check_system_chunk(struct btrfs_trans_handle *trans, u64 type)
>  {
> --
> 2.23.0
> 
>