linux-kernel - Re: [PATCH] PCI/MSI: Enable PCI_MSI_IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20191008124723.GA161444@google.com>
Date:   Tue, 8 Oct 2019 07:47:23 -0500
From:   Bjorn Helgaas <helgaas@...nel.org>
To:     Michal Simek <michal.simek@...inx.com>
Cc:     linux-kernel@...r.kernel.org, monstr@...str.eu, git@...inx.com,
        Kuldeep Dave <kuldeep.dave@...inx.com>,
        linux-pci@...r.kernel.org
Subject: Re: [PATCH] PCI/MSI: Enable PCI_MSI_IRQ_DOMAIN support for Microblaze

On Tue, Oct 08, 2019 at 12:39:22PM +0200, Michal Simek wrote:
> From: Kuldeep Dave <kuldeep.dave@...inx.com>
> 
> Add Microblaze as an arch that supports PCI_MSI_IRQ_DOMAIN.
> Enabling msi.h generation is done by separate patch.
> 
> Similar change was done by commit 2a9af0273c1c
> ("PCI/MSI: Enable PCI_MSI_IRQ_DOMAIN support for RISC-V")
> 
> Signed-off-by: Kuldeep Dave <kuldeep.dave@...inx.com>
> Signed-off-by: Bharat Kumar Gogada <bharat.kumar.gogada@...inx.com>
> Signed-off-by: Michal Simek <michal.simek@...inx.com>

Acked-by: Bjorn Helgaas <bhelgaas@...gle.com>

> Arch part was sent here:
> https://lkml.org/lkml/2019/10/8/277

Can you please squash this drivers/pci/Kconfig change into the same
patch as the arch/microblaze patch mentioned above?  That way there's
no ordering issue between the two patches.  I'd be glad to merge it,
or you can add my ack and apply it via the Microblaze tree.  Just let
me know which you prefer so I know whether to do something with this.

Sorry; I probably suggested the splitting in the first place for
RISC-V, but I think that was a mistake.

> ---
>  drivers/pci/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/pci/Kconfig b/drivers/pci/Kconfig
> index a304f5ea11b9..9d259372fbfd 100644
> --- a/drivers/pci/Kconfig
> +++ b/drivers/pci/Kconfig
> @@ -52,7 +52,7 @@ config PCI_MSI
>  	   If you don't know what to do here, say Y.
>  
>  config PCI_MSI_IRQ_DOMAIN
> -	def_bool ARC || ARM || ARM64 || X86 || RISCV
> +	def_bool ARC || ARM || ARM64 || X86 || RISCV || MICROBLAZE
>  	depends on PCI_MSI
>  	select GENERIC_MSI_IRQ_DOMAIN
>  
> -- 
> 2.17.1
>