linux-kernel - Re: [PATCH][next] efi/tpm: fix sanity check of unsigned tbl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 8 Oct 2019 08:47:44 -0700
From:   Jerry Snitselaar <jsnitsel@...hat.com>
To:     Colin King <colin.king@...onical.com>
Cc:     Ard Biesheuvel <ard.biesheuvel@...aro.org>,
        Ingo Molnar <mingo@...nel.org>, linux-efi@...r.kernel.org,
        kernel-janitors@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH][next] efi/tpm: fix sanity check of unsigned tbl_size
 being less than zero

On Tue Oct 08 19, Colin King wrote:
>From: Colin Ian King <colin.king@...onical.com>
>
>Currently the check for tbl_size being less than zero is always false
>because tbl_size is unsigned. Fix this by making it a signed int.
>
>Addresses-Coverity: ("Unsigned compared against 0")
>Fixes: e658c82be556 ("efi/tpm: Only set 'efi_tpm_final_log_size' after successful event log parsing")
>Signed-off-by: Colin Ian King <colin.king@...onical.com>
>---
> drivers/firmware/efi/tpm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/firmware/efi/tpm.c b/drivers/firmware/efi/tpm.c
>index 703469c1ab8e..ebd7977653a8 100644
>--- a/drivers/firmware/efi/tpm.c
>+++ b/drivers/firmware/efi/tpm.c
>@@ -40,7 +40,7 @@ int __init efi_tpm_eventlog_init(void)
> {
> 	struct linux_efi_tpm_eventlog *log_tbl;
> 	struct efi_tcg2_final_events_table *final_tbl;
>-	unsigned int tbl_size;
>+	int tbl_size;
> 	int ret = 0;
>
> 	if (efi.tpm_log == EFI_INVALID_TABLE_ADDR) {
>-- 
>2.20.1
>

Thanks for catching that. Somehow I dropped it from v2 to v3.