linux-kernel - Re: [PATCH RFC] kconfig: add hvconfig for Linux on Hyper-V

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20191008161001.lwiduq4mlyjumw5b@debian>
Date:   Tue, 8 Oct 2019 17:10:01 +0100
From:   Wei Liu <wei.liu@...nel.org>
To:     Masahiro Yamada <yamada.masahiro@...ionext.com>
Cc:     Wei Liu <wei.liu@...nel.org>,
        Linux on Hyper-V List <linux-hyperv@...r.kernel.org>,
        Linux Kernel List <linux-kernel@...r.kernel.org>,
        Linux Kconfig List <linux-kbuild@...r.kernel.org>,
        Wei Liu <liuwe@...rosoft.com>
Subject: Re: [PATCH RFC] kconfig: add hvconfig for Linux on Hyper-V

On Wed, Oct 09, 2019 at 01:03:19AM +0900, Masahiro Yamada wrote:
[...]
> > diff --git a/scripts/kconfig/Makefile b/scripts/kconfig/Makefile
> > index ef2f2336c469..2ee46301b22e 100644
> > --- a/scripts/kconfig/Makefile
> > +++ b/scripts/kconfig/Makefile
> > @@ -104,6 +104,10 @@ PHONY += xenconfig
> >  xenconfig: xen.config
> >         @:
> >
> > +PHONY += hvconfig
> > +hvconfig: hv_guest.config
> > +       @:
> > +
> 
> 
> Does this need to be hooked up to kconfig Makefile?
> 

It is not strictly necessary. Just thought it would be nice to follow
existing examples.

> In my understanding, this code provides
> "make hvconfig" as a shorthand for "make hv_guest.config"
> 

Yes that's correct.

> Please do not do this.
> 
> 
> See "xenconfig" as a bad example.
> 
> "make xenconfig" is a shorthand of "make xen.config".
> This exists to save just one character typing.
> 
> 
> If I allow this, people would push more and more random pointless shorthands,
> which are essentially unrelated to kconfig.
> 
> 
> kvmconfig and xenconfig are just historical mistakes.
> 
> 
> Please drop the changes to scripts/kconfig/Makefile.

OK.

> 
> Also, please do not use misleading "kconfig:" for the subject prefix.
> You can use the subject prefix "hyper-v:" or something.
> 

OK.

Wei.