linux-kernel - Re: [PATCH] ARM: dts: s3c64xx: Fix init order of clock providers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ceede424-e4a2-03f1-3ce0-04f405688721@samsung.com>
Date:   Tue, 8 Oct 2019 19:30:50 +0200
From:   Sylwester Nawrocki <s.nawrocki@...sung.com>
To:     Krzysztof Kozlowski <krzk@...nel.org>,
        Lihua Yao <ylhuajnu@...look.com>
Cc:     linux-arm-kernel@...ts.infradead.org,
        linux-samsung-soc@...r.kernel.org, devicetree@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH] ARM: dts: s3c64xx: Fix init order of clock providers

On 10/8/19 18:59, Krzysztof Kozlowski wrote:
> From: Lihua Yao <ylhuajnu@...look.com>
> 
> fin_pll is the parent of clock-controller@...0f000, specify
> the dependency to ensure proper initialization order of clock
> providers.

> Fixes: 3f6d439f2022 ("clk: reverse default clk provider initialization order in of_clk_init()")

The patch looks good but I'm not sure above tag points to the right commit.
That commit is just a regression fix for
1771b10d605d26cc "clk: respect the clock dependencies in of_clk_init"
 
How about picking some commit touching the dts files itself, e.g.
a43736deb47d21bd "ARM: dts: Add dts file for S3C6410-based Mini6410 board" ?

> Signed-off-by: Lihua Yao <ylhuajnu@...look.com>
> Signed-off-by: Krzysztof Kozlowski <krzk@...nel.org>

Reviewed-by: Sylwester Nawrocki <s.nawrocki@...sung.com>

-- 
Regards,
Sylwester