linux-kernel - Re: [PATCH] mm, page_alloc: drop pointless static qualifier in build

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.21.1910081906120.4398@www.lameter.com>
Date:   Tue, 8 Oct 2019 19:06:57 +0000 (UTC)
From:   Christopher Lameter <cl@...ux.com>
To:     Kaitao Cheng <pilgrimtao@...il.com>
cc:     akpm@...ux-foundation.org, sashal@...nel.org, mhocko@...e.com,
        osalvador@...e.de, mgorman@...hsingularity.net, rppt@...ux.ibm.com,
        dan.j.williams@...el.com, alexander.h.duyck@...ux.intel.com,
        pavel.tatashin@...rosoft.com, glider@...gle.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        Muchun Song <smuchun@...il.com>
Subject: Re: [PATCH] mm, page_alloc: drop pointless static qualifier in
 build_zonelists()

On Sat, 28 Sep 2019, Kaitao Cheng wrote:

> There is no need to make the 'node_order' variable static
> since new value always be assigned before use it.

In the past MAX_NUMMNODES could become quite large like 512 or 1k. Large
array allocations on the stack are problematic.

Maybe that is no longer the case?