linux-kernel - Re: [PATCH 6/6] x86/fpu/xstate: Rename validate_xstate_header() to validate_xstate_header_from

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d733c8d7c7c7c27ac6e89374bfb78891119e3b02.camel@intel.com>
Date:   Wed, 09 Oct 2019 15:10:54 -0700
From:   Yu-cheng Yu <yu-cheng.yu@...el.com>
To:     Borislav Petkov <bp@...en8.de>
Cc:     linux-kernel@...r.kernel.org, x86@...nel.org,
        "H. Peter Anvin" <hpa@...or.com>,
        Thomas Gleixner <tglx@...utronix.de>,
        Ingo Molnar <mingo@...hat.com>,
        Dave Hansen <dave.hansen@...ux.intel.com>,
        Tony Luck <tony.luck@...el.com>,
        Andy Lutomirski <luto@...nel.org>,
        Rik van Riel <riel@...riel.com>,
        "Ravi V. Shankar" <ravi.v.shankar@...el.com>,
        Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
        Fenghua Yu <fenghua.yu@...el.com>,
        Peter Zijlstra <peterz@...radead.org>
Subject: Re: [PATCH 6/6] x86/fpu/xstate: Rename validate_xstate_header() to
 validate_xstate_header_from_user()

On Wed, 2019-10-09 at 19:31 +0200, Borislav Petkov wrote:
> On Wed, Sep 25, 2019 at 08:10:22AM -0700, Yu-cheng Yu wrote:
> > From: Fenghua Yu <fenghua.yu@...el.com>
> > 
> > The function validate_xstate_header() validates an xstate header coming
> > from userspace (PTRACE or sigreturn).  To make it clear, rename it to
> > validate_xstate_header_from_user().
> > 
> > Suggested-by: Dave Hansen <dave.hansen@...el.com>
> > Signed-off-by: Fenghua Yu <fenghua.yu@...el.com>
> > Signed-off-by: Yu-cheng Yu <yu-cheng.yu@...el.com>
> 
> This one is correct!
> 
> \o/
> 
> > Reviewed-by: Dave Hansen <dave.hansen@...ux.intel.com>
> > Reviewed-by: Tony Luck <tony.luck@...el.com>
> > ---
> >  arch/x86/include/asm/fpu/xstate.h | 2 +-
> >  arch/x86/kernel/fpu/regset.c      | 2 +-
> >  arch/x86/kernel/fpu/signal.c      | 2 +-
> >  arch/x86/kernel/fpu/xstate.c      | 6 +++---
> >  4 files changed, 6 insertions(+), 6 deletions(-)
> 
> And I like patches like this one! :-)
> 
> Reviewed-by: Borislav Petkov <bp@...e.de>

Thanks for reviewing.  I will send out an updated version.

Yu-cheng