linux-kernel - RE: [PATCH] tty: serial: imx: Only get second/third IRQ when there is more than one IRQ

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <DB3PR0402MB39161E02A9D042948B71FDCDF5950@DB3PR0402MB3916.eurprd04.prod.outlook.com>
Date:   Wed, 9 Oct 2019 07:24:57 +0000
From:   Anson Huang <anson.huang@....com>
To:     Uwe Kleine-König 
        <u.kleine-koenig@...gutronix.de>
CC:     Stephen Boyd <swboyd@...omium.org>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "jslaby@...e.com" <jslaby@...e.com>,
        "shawnguo@...nel.org" <shawnguo@...nel.org>,
        "s.hauer@...gutronix.de" <s.hauer@...gutronix.de>,
        "kernel@...gutronix.de" <kernel@...gutronix.de>,
        "festevam@...il.com" <festevam@...il.com>,
        "linux-serial@...r.kernel.org" <linux-serial@...r.kernel.org>,
        "linux-arm-kernel@...ts.infradead.org" 
        <linux-arm-kernel@...ts.infradead.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
        dl-linux-imx <linux-imx@....com>,
        "Rafael J. Wysocki" <rafael.j.wysocki@...el.com>,
        Andy Shevchenko <andy.shevchenko@...il.com>
Subject: RE: [PATCH] tty: serial: imx: Only get second/third IRQ when there is
 more than one IRQ

Hi, Uwe

> On Wed, Oct 09, 2019 at 06:58:24AM +0000, Anson Huang wrote:
> > > On Wed, Oct 09, 2019 at 02:18:31PM +0800, Anson Huang wrote:
> > > > All i.MX SoCs except i.MX1 have ONLY 1 IRQ, so it is better to
> > > > check the IRQ count before getting second/third IRQ to avoid below
> > > > error message during probe:
> > > >
> > > > [    0.726219] imx-uart 30860000.serial: IRQ index 1 not found
> > > > [    0.731329] imx-uart 30860000.serial: IRQ index 2 not found
> > >
> > > This message was introduced in commit
> > > 7723f4c5ecdb8d832f049f8483beb0d1081cedf6 for 5.4-rc1. I added the
> > > involved people to the recipents of this mail.
> >
> > Yes, I noticed this, thanks.
> >
> > >
> > > > Signed-off-by: Anson Huang <Anson.Huang@....com>
> > > > ---
> > > >  drivers/tty/serial/imx.c | 13 +++++++++++--
> > > >  1 file changed, 11 insertions(+), 2 deletions(-)
> > > >
> > > > diff --git a/drivers/tty/serial/imx.c b/drivers/tty/serial/imx.c
> > > > index
> > > > 504d81c..081fa82 100644
> > > > --- a/drivers/tty/serial/imx.c
> > > > +++ b/drivers/tty/serial/imx.c
> > > > @@ -2198,6 +2198,7 @@ static int imx_uart_probe(struct
> > > > platform_device
> > > *pdev)
> > > >  	u32 ucr1;
> > > >  	struct resource *res;
> > > >  	int txirq, rxirq, rtsirq;
> > > > +	int irq_count;
> > > >
> > > >  	sport = devm_kzalloc(&pdev->dev, sizeof(*sport), GFP_KERNEL);
> > > >  	if (!sport)
> > > > @@ -2220,9 +2221,17 @@ static int imx_uart_probe(struct
> > > platform_device *pdev)
> > > >  	if (IS_ERR(base))
> > > >  		return PTR_ERR(base);
> > > >
> > > > +	irq_count = platform_irq_count(pdev);
> > > > +	if (irq_count < 0)
> > > > +		return irq_count;
> > > > +
> > > >  	rxirq = platform_get_irq(pdev, 0);
> > > > -	txirq = platform_get_irq(pdev, 1);
> > > > -	rtsirq = platform_get_irq(pdev, 2);
> > > > +	if (irq_count > 1) {
> > > > +		txirq = platform_get_irq(pdev, 1);
> > > > +		rtsirq = platform_get_irq(pdev, 2);
> > > > +	} else {
> > > > +		txirq = rtsirq = -ENXIO;
> > > > +	}
> > >
> > > The patch is fine given the changed behaviour of platform_get_irq. I
> > > wonder if it is sensible to introduce a variant of platform_get_irq
> > > (say
> > > platform_get_irq_nowarn) that behaves like __platform_get_irq does t
> > > Then the imx driver would just call platform_get_irq_nowarn without
> > > having to check the number of available irqs first.
> >
> > Agreed, it would be nice if we can fix this from the API level, this
> > is to save many patches from various drivers side, let me know if
> > agreement is reached and I will do the patch.
> 
> I wouldn't expect that most callers actually want an error message and so
> these need a different patch (i.e. dropping the error message by the caller).
> This type of patch is fine and the normal load when something is
> consolidated.
> 
> Which other drivers do you have on your radar that don't want an error
> message if platform_get_irq() fails?

I did NOT mean drivers don't want an error when getting irq failed, but I just
agree that introducing another API with nowarn as you mentioned upper, then
i.MX driver can call it. For now, the FEC driver also have many such error message,
we will fix later.

So if the API with nowarn is added, then I can change the API call in some i.MX driver
instead of getting irq_count first. Do you think I should add the nowarn API and redo
this patch to call it? 

Anson