linux-kernel - Re: [PATCH v2 5/6] rpmsg: glink: Don't send pending rx

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3e4a7fe5-fc7a-b7d5-19bf-7fb8a26d8e55@codeaurora.org>
Date:   Tue, 8 Oct 2019 18:08:46 -0700
From:   Chris Lew <clew@...eaurora.org>
To:     Bjorn Andersson <bjorn.andersson@...aro.org>,
        Ohad Ben-Cohen <ohad@...ery.com>
Cc:     linux-arm-msm@...r.kernel.org, linux-remoteproc@...r.kernel.org,
        linux-kernel@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH v2 5/6] rpmsg: glink: Don't send pending rx_done during
 remove



On 10/4/2019 3:27 PM, Bjorn Andersson wrote:
> Attempting to transmit rx_done messages after the GLINK instance is
> being torn down will cause use after free and memory leaks. So cancel
> the intent_work and free up the pending intents.
> 
> With this there are no concurrent accessors of the channel left during
> qcom_glink_native_remove() and there is therefor no need to hold the
> spinlock during this operation - which would prohibit the use of
> cancel_work_sync() in the release function. So remove this.
> 
> Fixes: 1d2ea36eead9 ("rpmsg: glink: Add rx done command")
> Cc: stable@...r.kernel.org
> Tested-by: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> Signed-off-by: Bjorn Andersson <bjorn.andersson@...aro.org>
> ---

Acked-By: Chris Lew <clew@...eaurora.org>

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
a Linux Foundation Collaborative Project